From: Mandeep Singh Baines <msb@chromium.org>
To: Tejun Heo <tj@kernel.org>
Cc: Mandeep Singh Baines <msb@chromium.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>
Subject: Re: [PATCH 3/3] cgroup: remove extra calls to find_existing_css_set
Date: Fri, 20 Jan 2012 18:57:12 -0800 [thread overview]
Message-ID: <20120121025712.GB4656@google.com> (raw)
In-Reply-To: <20120121000842.GB2908@dhcp-172-17-108-109.mtv.corp.google.com>
Tejun Heo (tj@kernel.org) wrote:
> On Tue, Jan 03, 2012 at 09:18:32PM -0800, Mandeep Singh Baines wrote:
> > +out_put_css_set_refs:
> > + if (retval) {
> > + for (i = 0; i < css_set_refs; i++) {
> > + tc = flex_array_get(group, i);
> > + put_css_set(tc->cg);
>
> Why not the following
>
> for (i = 0; i < group_size; i++) {
> tc = flex_array_get(group, i);
> if (tc)
> put_css_set(tc->cg);
> }
>
> and remove css_set_refs?
>
If I break out of step 2 via the goto (out_put_css_set_refs), I only
want to put back the refs I've gotten so far. I could reset group_size
in that case but wanted avoid overloading group_size: someone
could later add more error path code that isn't expecting that
group_size will get re-assigned and have its meaning change.
Regards,
Mandeep
> Thanks
>
> --
> tejun
next prev parent reply other threads:[~2012-01-21 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 5:18 [PATCH 1/3] cgroup: simplify double-check locking in cgroup_attach_proc Mandeep Singh Baines
2012-01-04 5:18 ` [PATCH 2/3] cgroup: replace tasklist_lock with rcu_read_lock Mandeep Singh Baines
2012-01-04 10:38 ` Frederic Weisbecker
2012-01-05 2:09 ` Li Zefan
2012-01-21 0:00 ` Tejun Heo
2012-01-04 5:18 ` [PATCH 3/3] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
2012-01-05 2:10 ` Li Zefan
2012-01-05 17:35 ` Tejun Heo
2012-01-21 0:08 ` Tejun Heo
2012-01-21 2:57 ` Mandeep Singh Baines [this message]
2012-01-21 5:52 ` Tejun Heo
2012-01-05 2:08 ` [PATCH 1/3] cgroup: simplify double-check locking in cgroup_attach_proc Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2011-12-23 0:57 [PATCH 1/3] cgroup: remove tasklist_lock from cgroup_attach_proc Mandeep Singh Baines
2011-12-23 0:57 ` [PATCH 3/3] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121025712.GB4656@google.com \
--to=msb@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).