From: Greg KH <gregkh@suse.de>
To: Kashyap Gada <gada.kashyap@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, bringert@android.com,
linux-kernel@vger.kernel.org, arve@android.com,
john.stultz@linaro.org, ccross@android.com
Subject: Re: [PATCH 4/4] Staging: android: Fix struct definitioni warning from static to const
Date: Sat, 21 Jan 2012 08:45:31 -0500 [thread overview]
Message-ID: <20120121134530.GA21457@suse.de> (raw)
In-Reply-To: <CANJXcUaxX8kTArQ3tL4hHnOVAq=yLzLjfMe1CbSi-n-UcW6dEw@mail.gmail.com>
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sat, Jan 21, 2012 at 01:19:51PM +0000, Kashyap Gada wrote:
> Greg Im just following your tutorials and when i check the mail im sending in
> terminal it comes proper but when i see the mail what was sent by git
> send-email it doest have any of these. How to ensure proper patch numbers.
Send them all at once.
Also, you forgot the patch description and the signed-off-by, which I
know is mentioned in the tutorial. Please read the file,
Documentation/SubmittingPatches please.
thanks,
greg k-h
prev parent reply other threads:[~2012-01-21 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 2:17 [PATCH 4/4] Staging: android: Fix struct definitioni warning from static to const Kashyap Gada
2012-01-21 8:08 ` Dan Carpenter
2012-01-21 12:53 ` Greg KH
[not found] ` <CANJXcUaxX8kTArQ3tL4hHnOVAq=yLzLjfMe1CbSi-n-UcW6dEw@mail.gmail.com>
2012-01-21 13:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120121134530.GA21457@suse.de \
--to=gregkh@suse.de \
--cc=arve@android.com \
--cc=bringert@android.com \
--cc=ccross@android.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gada.kashyap@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).