From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"durgadoss.r@intel.com" <durgadoss.r@intel.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH v2] thermal: thermal_sys: Fix build warning
Date: Sun, 22 Jan 2012 10:11:53 -0800 [thread overview]
Message-ID: <20120122181153.GA12212@ericsson.com> (raw)
In-Reply-To: <1327250761-7071-1-git-send-email-festevam@gmail.com>
On Sun, Jan 22, 2012 at 11:46:01AM -0500, Fabio Estevam wrote:
> Fix the following build warning:
>
> drivers/thermal/thermal_sys.c:63: warning: 'thermal_event_seqnum' defined but not used
>
> ,which happens when CONFIG_NET is not set.
>
> Move 'thermal_event_seqnum' definition inside the '#ifdef CONFIG_NET'
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Change since v1:
> - Sent corrupted patch in v1, and fixed now
> drivers/thermal/thermal_sys.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> index dd9a574..11f5955 100644
> --- a/drivers/thermal/thermal_sys.c
> +++ b/drivers/thermal/thermal_sys.c
> @@ -60,8 +60,6 @@ static LIST_HEAD(thermal_tz_list);
> static LIST_HEAD(thermal_cdev_list);
> static DEFINE_MUTEX(thermal_list_lock);
>
> -static unsigned int thermal_event_seqnum;
> -
> static int get_idr(struct idr *idr, struct mutex *lock, int *id)
> {
> int err;
> @@ -1304,6 +1302,8 @@ static struct genl_multicast_group thermal_event_mcgrp = {
> .name = THERMAL_GENL_MCAST_GROUP_NAME,
> };
>
> +static unsigned int thermal_event_seqnum;
> +
> int generate_netlink_event(u32 orig, enum events event)
> {
> struct sk_buff *skb;
> --
> 1.7.1
>
next prev parent reply other threads:[~2012-01-22 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 16:33 [PATCH] thermal: thermal_sys: Fix build warning Fabio Estevam
2012-01-22 16:46 ` [PATCH v2] " Fabio Estevam
2012-01-22 18:11 ` Guenter Roeck [this message]
2012-01-23 2:57 ` R, Durgadoss
2012-01-24 22:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120122181153.GA12212@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=akpm@linux-foundation.org \
--cc=durgadoss.r@intel.com \
--cc=festevam@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox