From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM
Date: Mon, 23 Jan 2012 11:21:43 +0000 [thread overview]
Message-ID: <20120123112142.GA29465@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1327313241.31594.12.camel@matrix>
On Mon, Jan 23, 2012 at 03:37:21PM +0530, Ashish Chavan wrote:
> +/* PLL out frequency values */
> +#define FOUT_2822400 2822400
> +#define FOUT_3072000 3072000
It's difficult to see what these defines are adding.
> +static const u32 da7210_fout_2822400_div[][DIV_CNT + 1] = {
> + { 12000000, 0xE8, 0x6C, 0x2, }, /* MCLK=12Mhz Fs=44.1Khz */
You're still using magic numbers to find the dividers, and clearly the
same rate comment should apply to the whole table not specific entries.
> + /* In PLL master mode, use master mode PLL dividers */
> + if (fout == FOUT_2822400) {
> + } else if (fout == FOUT_3072000) {
This looks like a switch statement and...
> + for (row_idx = 0; row_idx < FREF_CNT; row_idx++) {
ARRAY_SIZE()
> + if (fref == da7210_fout_3072000_div[row_idx]
> + [FREF_IDX]) {
> + pll_div1 =
> + da7210_fout_3072000_div[row_idx]
> + [DIV1_IDX];
...this code is shared between both branches (as well as the SRM case)
and should be factored out between them.
next parent reply other threads:[~2012-01-23 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1327313241.31594.12.camel@matrix>
2012-01-23 11:21 ` Mark Brown [this message]
[not found] ` <1327320561.31594.23.camel@matrix>
2012-01-23 12:03 ` [alsa-devel] [PATCH v2] ASoC: da7210: Add support for PLL and SRM Mark Brown
[not found] <1334666046.32225.8.camel@matrix>
2012-04-17 13:43 ` Mark Brown
[not found] ` <1334672460.13279.3.camel@matrix>
2012-04-17 14:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123112142.GA29465@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox