From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347Ab2AWQUm (ORCPT ); Mon, 23 Jan 2012 11:20:42 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:62963 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893Ab2AWQUl (ORCPT ); Mon, 23 Jan 2012 11:20:41 -0500 Date: Mon, 23 Jan 2012 08:20:35 -0800 From: Tejun Heo To: Vivek Goyal Cc: axboe@kernel.dk, ctalbott@google.com, rni@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/17] blkcg: shoot down blkio_groups on elevator switch Message-ID: <20120123162035.GF12652@google.com> References: <1327202725-3383-1-git-send-email-tj@kernel.org> <1327202725-3383-9-git-send-email-tj@kernel.org> <20120123152055.GD25986@redhat.com> <20120123153913.GB12652@google.com> <20120123155216.GF25986@redhat.com> <20120123155745.GD12652@google.com> <20120123161042.GG25986@redhat.com> <20120123161308.GH25986@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120123161308.GH25986@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2012 at 11:13:08AM -0500, Vivek Goyal wrote: > How about draining throttle groups only on queue exit (blk_cleanup_queue()) > and not on elevator switch. It's for possible policy changes and to fully manage blkg from blkcg. blkg itself needs to change as applied policies change and need to be flushed. -- tejun