From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785Ab2AWQo0 (ORCPT ); Mon, 23 Jan 2012 11:44:26 -0500 Received: from ovro.ovro.caltech.edu ([192.100.16.2]:36942 "EHLO ovro.ovro.caltech.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885Ab2AWQoZ (ORCPT ); Mon, 23 Jan 2012 11:44:25 -0500 Date: Mon, 23 Jan 2012 08:44:23 -0800 From: "Ira W. Snyder" To: Axel Lin Cc: linux-kernel@vger.kernel.org, Pratyush Anand , Pavan Savoy , Donggeun Kim , Arnd Bergmann , Greg Kroah-Hartman Subject: Re: [PATCH 1/3] MISC: convert drivers/misc/* to use module_platform_driver() Message-ID: <20120123164422.GA3649@ovro.caltech.edu> References: <1327217629.6497.0.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327217629.6497.0.camel@phoenix> User-Agent: Mutt/1.5.20 (2009-06-14) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (ovro.ovro.caltech.edu); Mon, 23 Jan 2012 08:44:25 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 22, 2012 at 03:33:49PM +0800, Axel Lin wrote: > This patch converts the drivers in drivers/misc/* to use the > module_platform_driver() macro which makes the code smaller and a bit > simpler. > > Signed-off-by: Axel Lin > Cc: Ira W. Snyder > Cc: Pratyush Anand > Cc: Pavan Savoy > Cc: Donggeun Kim > Acked-by: Arnd Bergmann > Acked-by: Pratyush Anand > --- > drivers/misc/carma/carma-fpga.c | 17 +---------------- > drivers/misc/max8997-muic.c | 12 +----------- > drivers/misc/spear13xx_pcie_gadget.c | 12 +----------- > drivers/misc/ti-st/st_kim.c | 13 +------------ > 4 files changed, 4 insertions(+), 50 deletions(-) > > diff --git a/drivers/misc/carma/carma-fpga.c b/drivers/misc/carma/carma-fpga.c > index 14e974b2..366bc15 100644 > --- a/drivers/misc/carma/carma-fpga.c > +++ b/drivers/misc/carma/carma-fpga.c > @@ -1410,23 +1410,8 @@ static struct platform_driver data_of_driver = { > }, > }; > > -/* > - * Module Init / Exit > - */ > - > -static int __init data_init(void) > -{ > - return platform_driver_register(&data_of_driver); > -} > - > -static void __exit data_exit(void) > -{ > - platform_driver_unregister(&data_of_driver); > -} > +module_platform_driver(data_of_driver); > > MODULE_AUTHOR("Ira W. Snyder "); > MODULE_DESCRIPTION("CARMA DATA-FPGA Access Driver"); > MODULE_LICENSE("GPL"); > - > -module_init(data_init); > -module_exit(data_exit); Looks great. Acked-by: Ira W. Snyder > diff --git a/drivers/misc/max8997-muic.c b/drivers/misc/max8997-muic.c > index d74ef41..19591ea 100644 > --- a/drivers/misc/max8997-muic.c > +++ b/drivers/misc/max8997-muic.c > @@ -488,17 +488,7 @@ static struct platform_driver max8997_muic_driver = { > .remove = __devexit_p(max8997_muic_remove), > }; > > -static int __init max8997_muic_init(void) > -{ > - return platform_driver_register(&max8997_muic_driver); > -} > -module_init(max8997_muic_init); > - > -static void __exit max8997_muic_exit(void) > -{ > - platform_driver_unregister(&max8997_muic_driver); > -} > -module_exit(max8997_muic_exit); > +module_platform_driver(max8997_muic_driver); > > MODULE_DESCRIPTION("Maxim MAX8997 MUIC driver"); > MODULE_AUTHOR("Donggeun Kim "); > diff --git a/drivers/misc/spear13xx_pcie_gadget.c b/drivers/misc/spear13xx_pcie_gadget.c > index 43d073b..123ed98 100644 > --- a/drivers/misc/spear13xx_pcie_gadget.c > +++ b/drivers/misc/spear13xx_pcie_gadget.c > @@ -891,17 +891,7 @@ static struct platform_driver spear_pcie_gadget_driver = { > }, > }; > > -static int __init spear_pcie_gadget_init(void) > -{ > - return platform_driver_register(&spear_pcie_gadget_driver); > -} > -module_init(spear_pcie_gadget_init); > - > -static void __exit spear_pcie_gadget_exit(void) > -{ > - platform_driver_unregister(&spear_pcie_gadget_driver); > -} > -module_exit(spear_pcie_gadget_exit); > +module_platform_driver(spear_pcie_gadget_driver); > > MODULE_ALIAS("platform:pcie-gadget-spear"); > MODULE_AUTHOR("Pratyush Anand"); > diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c > index a7a861c..7c14f8f 100644 > --- a/drivers/misc/ti-st/st_kim.c > +++ b/drivers/misc/ti-st/st_kim.c > @@ -837,19 +837,8 @@ static struct platform_driver kim_platform_driver = { > }, > }; > > -static int __init st_kim_init(void) > -{ > - return platform_driver_register(&kim_platform_driver); > -} > - > -static void __exit st_kim_deinit(void) > -{ > - platform_driver_unregister(&kim_platform_driver); > -} > - > +module_platform_driver(kim_platform_driver); > > -module_init(st_kim_init); > -module_exit(st_kim_deinit); > MODULE_AUTHOR("Pavan Savoy "); > MODULE_DESCRIPTION("Shared Transport Driver for TI BT/FM/GPS combo chips "); > MODULE_LICENSE("GPL"); > -- > 1.7.5.4 > > >