From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753451Ab2AWSOl (ORCPT ); Mon, 23 Jan 2012 13:14:41 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52499 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890Ab2AWSOk (ORCPT ); Mon, 23 Jan 2012 13:14:40 -0500 Date: Mon, 23 Jan 2012 10:13:57 -0800 From: Greg KH To: Konrad Rzeszutek Wilk Cc: Linus Torvalds , linux-kernel@vger.kernel.org, kay.sievers@vrfy.org, bp@amd64.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, lenb@kernel.org, xen-devel@lists.xensource.com Subject: Re: WARN... Device 'cpu1' does not have a release() function, it is broken and must be fixed. when doing 'xl vcpu-set 1' Message-ID: <20120123181357.GA27538@suse.de> References: <20120123180601.GA24553@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120123180601.GA24553@phenom.dumpdata.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2012 at 01:06:01PM -0500, Konrad Rzeszutek Wilk wrote: > When I bring a CPU down in a guest (which should be the same as bringing a > CPU down using the ACPI framework), I get this: > > [ 14.484206] SMP alternatives: switching to UP code > [ 14.514287] ------------[ cut here ]------------ > [ 14.514318] WARNING: at /home/konrad/linux-linus/drivers/base/core.c:194 device_release+0x82/0x90() > [ 14.514354] Device 'cpu1' does not have a release() function, it is broken and must be fixed. > [ 14.514386] Modules linked in: radeon fbcon tileblit font ttm bitblit softcursor drm_kms_helper xen_blkfront xen_netfront xen_fbfront fb_sys_fops sysimgblt sysfillrect syscopyarea xen_kbdfront xenfs xen_privcmd > [ 14.514557] Pid: 22, comm: xenwatch Not tainted 3.3.0-rc1 #1 > [ 14.514586] Call Trace: > [ 14.515094] [] warn_slowpath_common+0x7a/0xb0 > [ 14.515094] [] warn_slowpath_fmt+0x41/0x50 > [ 14.515094] [] device_release+0x82/0x90 > [ 14.515094] [] kobject_release+0x45/0x90 > [ 14.515094] [] kobject_put+0x2c/0x60 > [ 14.515094] [] put_device+0x12/0x20 > [ 14.515094] [] device_unregister+0x19/0x20 > [ 14.515094] [] unregister_cpu+0x4f/0x80 > [ 14.515094] [] arch_unregister_cpu+0x1c/0x20 > [ 14.515094] [] handle_vcpu_hotplug_event+0xc7/0xd0 > [ 14.515094] [] xenwatch_thread+0xb0/0x180 > [ 14.515094] [] ? wake_up_bit+0x40/0x40 > [ 14.515094] [] ? split+0xf0/0xf0 > [ 14.515094] [] kthread+0x96/0xa0 > [ 14.515094] [] kernel_thread_helper+0x4/0x10 > [ 14.515094] [] ? retint_restore_args+0x5/0x6 > [ 14.515094] [] ? gs_change+0x13/0x13 > [ 14.515094] ---[ end trace 8f70af51a2e2611f ]--- > > Looking at "commit e032d80774315869aa2285b217fdbbfed86c0b49 > Author: Greg Kroah-Hartman > Date: Mon Jan 16 14:40:28 2012 -0800 > > mce: fix warning messages about static struct mce_device > " > > it looks like the corret fix is to make the 'cpu_devices' in > arch/x86/kernel/topology.c to be changed to be more dynamic > (or perhaps have an empty release function)? {sigh} Yes, that's the correct fix, I'll do the same type of change I did for the MCE code here as well. Sorry we missed this one previously. I'll get this fixed soon. greg k-h