public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Serge Hallyn <serge.hallyn@canonical.com>,
	Dave Hansen <haveblue@us.ibm.com>,
	sukadev@linux.vnet.ibm.com, Andy Whitcroft <apw@canonical.com>,
	Matt Helsley <matthltc@us.ibm.com>,
	linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org
Subject: Re: [RFC] fix devpts mount behavior
Date: Tue, 24 Jan 2012 01:07:58 +0000	[thread overview]
Message-ID: <20120124010758.GJ23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CA+55aFzwOU137V6wtyBjessx05NJo2G4KV0rvTKWvC79A+o9iQ@mail.gmail.com>

On Mon, Jan 23, 2012 at 04:41:25PM -0800, Linus Torvalds wrote:

> Right. I think the opportunity for problems should be pretty small.
> 
> And it's not like the pty itself wouldn't continue to work - it's just
> that programs like /usr/bin/tty wouldn't be able to *find* it.
> 
> Although who knows - maybe there is some other subtle interaction.

FWIW, the subtle and nasty part in all that is  that you can mknod /dev/ptmx
and it *will* work, refering to the "initial" instance.  That's what
concerns me about the chroot scenarios -
	mknod /jail/dev/ptmx c 5 2
	mkdir /jail/dev/pts
	mount -t devpts /jail/dev/pts
	chroot /jail
works fine right now, but with that change behaviour will be all wrong -
opening /dev/ptmx inside of jail will grab you a pts, all right, but
it will *not* show up in (jail) /dev/pts/* as it does with the current
kernel.

Note that if you replace that mknod with symlink pts/ptmx /jail/dev/ptmx
the things will keep working.  However, that will _only_ work for kernels
with DEVPTS_MULTIPLE_INSTANCES - without it you won't get ptmx inside
devpts (which is arguably wrong, BTW)

  reply	other threads:[~2012-01-24  1:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24  0:05 [RFC] fix devpts mount behavior Serge Hallyn
2012-01-24  0:13 ` Linus Torvalds
2012-01-24  0:25   ` Serge Hallyn
2012-01-24  0:41     ` Linus Torvalds
2012-01-24  1:07       ` Al Viro [this message]
2012-01-24 18:21         ` Serge E. Hallyn
2012-01-24 20:16           ` Sukadev Bhattiprolu
2012-01-24 20:53             ` Serge E. Hallyn
2012-01-24 20:24         ` Eric W. Biederman
2012-01-24 22:02           ` Serge E. Hallyn
2012-01-24 22:54             ` Kay Sievers
2012-01-24 23:16               ` Serge Hallyn
2012-01-24 23:25                 ` Sukadev Bhattiprolu
2012-01-24 23:29                   ` Serge E. Hallyn
2012-01-24 23:27                 ` Kay Sievers
2012-01-28 19:51                   ` Serge Hallyn
2012-01-28 20:52                     ` Eric W. Biederman
2012-01-28 21:32                       ` Kay Sievers
2012-09-23  3:47                     ` [PATCH 0/4] devpts: " Eric W. Biederman
2012-09-23  3:48                       ` [PATCH 1/4] devpts: Remove CONFIG_DEVPTS_MULTIPLE_INSTANCES Eric W. Biederman
2012-09-23  3:49                       ` [PATCH 2/4] devpts: Set the default permissions of /dev/pts/ptmx and /dev/ptmx to 0666 Eric W. Biederman
2012-09-23  3:50                       ` [PATCH 3/4] devpts: Make the newinstance option historical Eric W. Biederman
2012-09-23  4:19                         ` Al Viro
2012-09-23  4:46                           ` Al Viro
2012-09-23  5:59                           ` Eric W. Biederman
2012-09-23  6:30                             ` Al Viro
2012-09-23  6:34                               ` Al Viro
2012-09-23  7:00                                 ` Eric W. Biederman
2012-09-23  3:51                       ` [PATCH 4/4] devpts: Update the documentation Eric W. Biederman
2012-09-23 16:48                       ` [PATCH 0/4] devpts: fix devpts mount behavior H. Peter Anvin
2012-09-23 17:42                         ` Eric W. Biederman
2012-09-23 17:44                           ` H. Peter Anvin
2012-01-24 23:35             ` [RFC] " Eric W. Biederman
2012-01-24 20:55       ` Sukadev Bhattiprolu
2012-01-24 21:19         ` Nick Bowler
2012-01-24  0:26   ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120124010758.GJ23916@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=apw@canonical.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthltc@us.ibm.com \
    --cc=serge.hallyn@canonical.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox