public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ludwig Nussel <ludwig.nussel@suse.de>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] debugfs: add mode, uid and gid options
Date: Tue, 24 Jan 2012 15:57:34 -0800	[thread overview]
Message-ID: <20120124235734.GA28585@kroah.com> (raw)
In-Reply-To: <1326729981-6605-1-git-send-email-ludwig.nussel@suse.de>

On Mon, Jan 16, 2012 at 05:06:21PM +0100, Ludwig Nussel wrote:
> Cautious admins may want to restrict access to debugfs. Currently a
> manual chown/chmod e.g. in an init script is needed to achieve that.
> Distributions that want to make the mount options configurable need
> to add extra config files. By allowing to set the root inode's uid,
> gid and mode via mount options no such hacks are needed anymore.
> Instead configuration becomes straight forward via fstab.
> 
> Signed-off-by: Ludwig Nussel <ludwig.nussel@suse.de>

Oops, no, I didn't apply this as I get a compiler warning with it
applied:

fs/debugfs/inode.c:244:2: warning: initialization from incompatible pointer type [enabled by default]
fs/debugfs/inode.c:244:2: warning: (near initialization for ‘debugfs_super_operations.show_options’) [enabled by default]

Please fix this and resend.

thanks,

greg k-h

  parent reply	other threads:[~2012-01-25  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16 16:06 [PATCH] debugfs: add mode, uid and gid options Ludwig Nussel
2012-01-24 23:55 ` Greg KH
2012-01-24 23:57 ` Greg KH [this message]
2012-01-25 10:52   ` Ludwig Nussel
  -- strict thread matches above, loose matches on Subject: below --
2011-12-14 13:39 Ludwig Nussel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120124235734.GA28585@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludwig.nussel@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox