Re: [PATCH] mm: vmscan: fix malused nr_reclaimed in shrinking zone

Hillf Danton
2012-01-26T03:19:20Z

Hi Andrew

On Thu, Jan 26, 2012 at 9:00 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> I'm thinking we have a bit of code rot happening here.  This comment:
>
>                /*
>                 * On large memory systems, scan >> priority can become
>                 * really large. This is fine for the starting priority;
>                 * we want to put equal scanning pressure on each zone.
>                 * However, if the VM has a harder time of freeing pages,
>                 * with multiple processes reclaiming pages, the total
>                 * freeing target can get unreasonably large.
>                 */
>
> seems to have little to do with the code which it is trying to
> describe.  Or at least, I'm not sure this is the best we can possibly
> do :(
>

Try to do it soon 8-)

>
> Also, your email client is adding MIME goop to the emails which mine
> (sylpheed) is unable to decrypt.  It turns "=" into "=3D" everywhere.
> This:
>
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: quoted-printable
>
> I blame sylpheed for this, but if you can make it stop, that would make
> my life easier, and perhaps others.
>

More care will take gmail later on.

Thanks
Hillf