From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] kconfig: fix new choices being skipped upon config update
Date: Thu, 26 Jan 2012 10:26:03 +0100 [thread overview]
Message-ID: <20120126092603.GQ6305@pengutronix.de> (raw)
In-Reply-To: <1327357745-9095-1-git-send-email-lacombar@gmail.com>
On Mon, Jan 23, 2012 at 05:29:05PM -0500, Arnaud Lacombe wrote:
> Running `oldconfig' after any of the following configuration change:
>
> either trivial addition, such as:
>
> config A
> bool "A"
>
> choice
> prompt "Choice ?"
> depends on A
>
> config CHOICE_B
> bool "Choice B"
>
> config CHOICE_C
> bool "Choice C"
> endchoice
>
> or more tricky change:
>
> OLD KCONFIG | NEW KCONFIG
> |
> | config A
> | bool "A"
> |
> choice | choice
> prompt "Choice ?" | prompt "Choice ?"
> |
> config CHOICE_C | config CHOICE_C
> bool "Choice C" | bool "Choice C"
> |
> config CHOICE_D | config CHOICE_D
> bool "Choice D" | bool "Choice D"
> endchoice |
> | config CHOICE_E
> | bool "Choice E"
> | depends on A
> | endchoice
>
> will not cause the choice to be considered as NEW, and thus not be asked. The
> cause of this behavior is that choice's novelty are computed statically right
> after the saved configuration has been read. At this point, the new dependency's
> value is still unknown and asserted to be `no'. Moreover, no update to this
> decision is made afterward.
>
> Correct this by dynamically evaluating a choice's novelty, and removing the
> static evaluation.
>
> Cc: linux-kbuild@vger.kernel.org
> Cc: LKML <linux-kernel@vger.kernel.org>,
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>
> Reported-by: Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
(Please note the umlaut o in my name. If you have problems with that,
please at least write Kleine-Koenig.)
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
Best regards and thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2012-01-26 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120120164036.GO4066@pengutronix.de>
2012-01-23 22:29 ` [PATCH] kconfig: fix new choices being skipped upon config update Arnaud Lacombe
2012-01-26 9:26 ` Uwe Kleine-König [this message]
2012-01-26 10:06 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126092603.GQ6305@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).