From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292Ab2AZKxg (ORCPT ); Thu, 26 Jan 2012 05:53:36 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:44697 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257Ab2AZKxf (ORCPT ); Thu, 26 Jan 2012 05:53:35 -0500 Date: Thu, 26 Jan 2012 10:53:32 +0000 From: Mark Brown To: Julia Lawall Cc: Dong Aisheng-B29396 , Liam Girdwood , "kernel-janitors@vger.kernel.org" , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Message-ID: <20120126105331.GA8041@opensource.wolfsonmicro.com> References: <1326362117-29371-1-git-send-email-Julia.Lawall@lip6.fr> <7FE21149F4667147B645348EC605788508FBDB@039-SN2MPN1-013.039d.mgd.msft.net> <20120124202203.GD1135@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline In-Reply-To: X-Cookie: If you can read this, you're too close. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 24, 2012 at 09:45:26PM +0100, Julia Lawall wrote: > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > function. This is a really nice cleanup - I tried to apply it but unfortunately it needs a rebase due to the change to use clk_prepare()/clk_unprepare() which went in recently. Could you rebase against current -next please? --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPITCgAAoJEBus8iNuMP3dwdsQAJ56S/crd3AxbmMkzZ3Mw98q hnczJz2G63Ox7lPwugL9sj1fqFmQjZYuJfwrgqntrSkPuJ5iOVFQrmOAlJS8Oi7X W2tJUtzZWZKI0B90SglcMkULpG+qkCaQ3CMXHxdkFqEFQ7MJzd609kugWkCJS5ou gOGLXt0FyE6iwlZmn9nRqrNDjLeECKMfF5BMlAJ72EARWOSMBwsyKvxfUpCwoTKQ OToQxW2uljtrKu8w907MubWZAWXhSZ7nVVUNd2rC4K9Ri1ssdNKLL04TTxNdGHop FmLoSb9sKZp2j0op32bwnrZlKxIa7isTocBepW7LZLMMI8iIISt1cYqw/Rmv9G14 EIPiiANQIyZrrkwMRZO8UNlmM+6pxiQg62Ns53UY2vsVJI99DiMcyYXrPUfDvXt0 qILSCMs8xkqSJDxrPcZJyTFP+StuHSs5s5woh4MohUn2Lc18izmayaudT9ni8eL1 S5ngXgV8xzuiGeHCRDz4nzkk3JlRKwlhiWL7oV1Cu40mrthvROPEVaxlJwEfhGeC cvIdfPYhu9gM9RqCK9UsKVTHEG2MkEkM6p0BTcazEWSUkZ8YsXDo5m6iWU20URXK CW47OINCBV2PpTZEfO+mTQoQCVXVwAVZPR5GZmRhEzpOwSHinnd5Ce+UOli2rLYI Teuo5tyqs3JDa+VlO7uO =yVEa -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--