From: Ingo Molnar <mingo@elte.hu>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, Borislav Petkov <bp@amd64.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [GIT PULL] MCE recovery changes
Date: Thu, 26 Jan 2012 19:28:42 +0100 [thread overview]
Message-ID: <20120126182842.GA8630@elte.hu> (raw)
In-Reply-To: <CA+8MBbKyoM330hL830PtUz9+EVxkxVVyHcL_PbN+zYRs-BXQiw@mail.gmail.com>
* Tony Luck <tony.luck@intel.com> wrote:
> On Thu, Jan 26, 2012 at 2:46 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > It worked perfectly.
>
> Hurrah!
>
> > Pulled, thanks!
>
> Thank you.
>
> > One thing i noticed was the magic constant 0x134:
> >
> > + SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|0x0134),
> >
> > don't we want that defined a bit more clearly?
>
> Stylistically it is compatible with the existing:
> MASK(MCI_STATUS_OVER|MCI_UC_SAR|0xfff0, MCI_UC_S|0x00c0)
> and
> MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCACOD, MCI_UC_S|0x017a)
>
> ... but that's just a sign that they need some love too :-)
>
> I'll see what I can do - but meaningful names will clearly be
> longer than the hex constants that they replace - and I'm
> already pushing line length limits here, so it will need more
> than a trivial restructure.
Well, one option is to let the line grow - for such things it's
ok up to 100 cols or so.
Thanks,
Ingo
next prev parent reply other threads:[~2012-01-26 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 23:06 [GIT PULL] MCE recovery changes Luck, Tony
2012-01-26 10:46 ` Ingo Molnar
2012-01-26 17:29 ` Tony Luck
2012-01-26 18:28 ` Ingo Molnar [this message]
2012-01-27 0:02 ` [PATCH] x86/mce: Replace hard coded hex constants with symbolic defines Tony Luck
2012-01-27 10:49 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126182842.GA8630@elte.hu \
--to=mingo@elte.hu \
--cc=bp@amd64.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).