From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-pci@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Probing unconfigured PCI bridge resouces
Date: Fri, 27 Jan 2012 09:36:58 -0800 [thread overview]
Message-ID: <20120127093658.27dc258b@jbarnes-desktop> (raw)
In-Reply-To: <1327380633.19850.33.camel@pasglop>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Tue, 24 Jan 2012 15:50:33 +1100
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Tue, 2012-01-24 at 15:25 +1100, Benjamin Herrenschmidt wrote:
> .../...
>
> > Or am I missing some important fact here ?
>
> Ok, I think I was missing pci_bridge_check_ranges(), gotta figure now
> why this didn't kick in properly for me, probably some arch code
> crackpot.
>
> One thing I noticed is that we do clear IORESOURCE_UNSET in setup-res.c
> when setting up a device resource but we don't clear it for bridges in
> generic code ever, so it leaks all the way through from my early arch
> code. Not a big deal but annoying.
Maybe you can fix that when you unify your arch resource handling code
with the core one day. :)
There have been a lot of changes to handle re-allocation and such, and
I'm sure there's more duplication now...
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-27 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 4:25 Probing unconfigured PCI bridge resouces Benjamin Herrenschmidt
2012-01-24 4:50 ` Benjamin Herrenschmidt
2012-01-27 17:36 ` Jesse Barnes [this message]
2012-01-27 22:16 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127093658.27dc258b@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox