From: Rabin Vincent <rabin@rab.in>
To: John Stultz <john.stultz@linaro.org>
Cc: Andreas Friedrich <afrie@gmx.net>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com
Subject: Re: REGRESSION 3.2-rcX: RTC auto poweron after 5 minutes
Date: Sat, 28 Jan 2012 09:22:21 +0530 [thread overview]
Message-ID: <20120128035221.GA19279@debian> (raw)
In-Reply-To: <1327365073.11738.2.camel@work-vm>
On Mon, Jan 23, 2012 at 04:31:13PM -0800, John Stultz wrote:
> On Tue, 2011-12-27 at 20:07 +0530, Rabin Vincent wrote:
> > diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c
> > index 3bcc7cf..54a3b5e 100644
> > --- a/drivers/rtc/interface.c
> > +++ b/drivers/rtc/interface.c
> > @@ -778,16 +778,10 @@ static int rtc_timer_enqueue(struct rtc_device
> > *rtc, struct rtc_timer *timer)
> >
> > static void rtc_alarm_disable(struct rtc_device *rtc)
> > {
> > - struct rtc_wkalrm alarm;
> > - struct rtc_time tm;
> > -
> > - __rtc_read_time(rtc, &tm);
> > -
> > - alarm.time = rtc_ktime_to_tm(ktime_add(rtc_tm_to_ktime(tm),
> > - ktime_set(300, 0)));
> > - alarm.enabled = 0;
> > + if (!rtc->ops || !rtc->ops->alarm_irq_enable)
> > + return;
> >
> > - ___rtc_set_alarm(rtc, &alarm);
> > + rtc->ops->alarm_irq_enable(rtc->dev.parent, false);
> > }
> >
>
> Just wanted to close out on this. I know this change worked for
> Andreas, but did it also resolve the original issue for you?
Yes, the original issue remains fixed after this change.
Thanks.
prev parent reply other threads:[~2012-01-28 3:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 14:58 REGRESSION 3.2-rcX: RTC auto poweron after 5 minutes Andreas Friedrich
2011-12-27 10:57 ` Andreas Friedrich
2011-12-27 14:37 ` Rabin Vincent
2012-01-02 23:10 ` Andreas Friedrich
2012-01-03 20:00 ` John Stultz
2012-01-24 0:31 ` John Stultz
2012-01-28 3:52 ` Rabin Vincent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128035221.GA19279@debian \
--to=rabin@rab.in \
--cc=afrie@gmx.net \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox