From: Wolfram Sang <w.sang@pengutronix.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: Convert jz4740_wdt driver to watchdog core
Date: Sat, 28 Jan 2012 23:19:45 +0100 [thread overview]
Message-ID: <20120128221945.GA26708@pengutronix.de> (raw)
In-Reply-To: <1327572645.25187.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Thu, Jan 26, 2012 at 06:10:45PM +0800, Axel Lin wrote:
> This patch converts jz4740_wdt driver to use watchdog core APIs.
> Also use devm_* APIs to save a few error handling code.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Paul Cercueil <paul@crapouillou.net>
> ---
> v3: - Remove unused define for WDT_IN_USE and WDT_OK_TO_CLOSE
> - Remove mem from struct jz4740_wdt_drvdata
>
> v2: Address all the comments by Wolfram.
> - Remove unneed header file inclusion
> - Drop 'heartbeat' usage in jz4740_wdt_set_heartbeat and jz4740_wdt_start
> - Init wdt_dev->timeout in probe using the global 'heartbeat'
> - Remove unneed pointer check for drvdata->mem
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-01-28 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 10:10 [PATCH v3] watchdog: Convert jz4740_wdt driver to watchdog core Axel Lin
2012-01-28 22:19 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128221945.GA26708@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=axel.lin@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox