From: Daniel Vetter <daniel@ffwll.ch>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Keith Packard <keithp@keithp.com>, Takashi Iwai <tiwai@suse.de>,
"intel-gfx@lists.freedesktop..."
<intel-gfx@lists.freedesktop.org>, Michal Marek <mmarek@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
Robert Lemaire <rlemaire@suse.com>
Subject: Re: [PATCH][rebased] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
Date: Sun, 29 Jan 2012 16:14:21 +0100 [thread overview]
Message-ID: <20120129151421.GC4312@phenom.ffwll.local> (raw)
In-Reply-To: <20120129132326.GA4123@localhost>
On Sun, Jan 29, 2012 at 09:23:26PM +0800, Wu Fengguang wrote:
> > > Daniel, this is now based on linux-next. I use quilt, hope it also
> > > works for you :)
> >
> > On a quick check this patch is missing the hunk to actually write the
> > aud configuration into the register. I presume that's not intentional,
> > so can you please resend?
>
> This is weird, my outbox has the below chunk. Anyway here is the
> attached patch.
>
> @@ -6107,7 +6111,9 @@ static void ironlake_write_eld(struct dr
> if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
> DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n");
> eld[5] |= (1 << 2); /* Conn_Type, 0x1 = DisplayPort */
> - }
> + I915_WRITE(aud_config, AUD_CONFIG_N_VALUE_INDEX); /* 0x1 = DP */
> + } else
> + I915_WRITE(aud_config, 0);
>
> Thanks,
> Fengguang
Yeah, the hunk is here, too ... Looks like I've failed with wrestling the
quilt patch a bit, sorry for the noise. But I think I've got the handle on
that now. So queued for -next, thanks for the patch.
Yours, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-01-29 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 13:17 [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort Wu Fengguang
2012-01-09 17:22 ` Keith Packard
2012-01-10 5:45 ` Wu Fengguang
2012-01-12 17:33 ` Keith Packard
2012-01-16 8:02 ` Wu Fengguang
2012-01-16 20:26 ` [Intel-gfx] " Daniel Vetter
2012-01-16 20:44 ` Keith Packard
2012-01-16 23:08 ` Wu Fengguang
2012-01-16 23:15 ` Keith Packard
2012-01-17 10:22 ` Daniel Vetter
2012-01-29 4:44 ` [PATCH][rebased] " Wu Fengguang
2012-01-29 12:12 ` Daniel Vetter
2012-01-29 13:23 ` Wu Fengguang
2012-01-29 15:14 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120129151421.GC4312@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=fengguang.wu@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=rlemaire@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).