From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512Ab2A3Fnn (ORCPT ); Mon, 30 Jan 2012 00:43:43 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:54925 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215Ab2A3FnD (ORCPT ); Mon, 30 Jan 2012 00:43:03 -0500 Date: Mon, 30 Jan 2012 06:42:59 +0100 From: Frederic Weisbecker To: Jiri Olsa Cc: rostedt@goodmis.org, mingo@redhat.com, paulus@samba.org, acme@ghostprotocols.net, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, aarapov@redhat.com Subject: Re: [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Message-ID: <20120130054257.GB22447@somewhere> References: <1326912275-26405-1-git-send-email-jolsa@redhat.com> <1327776209-4883-1-git-send-email-jolsa@redhat.com> <1327776209-4883-2-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1327776209-4883-2-git-send-email-jolsa@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 28, 2012 at 07:43:23PM +0100, Jiri Olsa wrote: > Currently the ftrace_set_filter and ftrace_set_notrace functions > do not return any return code. So there's no way for ftrace_ops > user to tell wether the filter was correctly applied. > > The set_ftrace_filter interface returns error in case the filter > did not match: > > # echo krava > set_ftrace_filter > bash: echo: write error: Invalid argument > > Changing both ftrace_set_filter and ftrace_set_notrace functions > to return zero if the filter was applied correctly or -E* values > in case of error. > > Signed-off-by: Jiri Olsa Acked-by: Frederic Weisbecker