From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753603Ab2A3UEu (ORCPT ); Mon, 30 Jan 2012 15:04:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43655 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721Ab2A3UEt (ORCPT ); Mon, 30 Jan 2012 15:04:49 -0500 Date: Mon, 30 Jan 2012 18:04:32 -0200 From: Arnaldo Carvalho de Melo To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, robert.richter@amd.com Subject: Re: [PATCH] perf: fix broken perf inject -b Message-ID: <20120130200432.GC5797@infradead.org> References: <20120113144731.GA5458@quad> <20120113165315.GA24387@infradead.org> <20120130190008.GA5797@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Jan 30, 2012 at 08:53:26PM +0100, Stephane Eranian escreveu: > On Mon, Jan 30, 2012 at 8:00 PM, Arnaldo Carvalho de Melo > wrote: > > > > Em Mon, Jan 16, 2012 at 07:53:28PM +0100, Stephane Eranian escreveu: > > > On Fri, Jan 13, 2012 at 5:54 PM, Stephane Eranian wrote: > > > > On Fri, Jan 13, 2012 at 5:53 PM, Arnaldo Carvalho de Melo wrote: > > > >> Em Fri, Jan 13, 2012 at 03:47:31PM +0100, Stephane Eranian escreveu: > > > >>> perf inject -b was broken. It would not inject any build_ids > > > >>> into the stream. Furthermore, it would strip samples from the > > > >>> stream. > > > > > >>> @@ -173,6 +178,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool, > > > >>>               goto repipe; > > > >>>       } > > > >>> +     machine->pid = event->ip.pid; > > > > > I noticed that this statement conflicts with perf buildid-list (which > > > I am also fixing for pipe mode). > > > > > I don't quite understand why, though. > > > > Have you reached any conclusion about this problem? I haven't looked at > > it in detail, could you please elaborate more? > > > > I ended up removing it. But I am not sure this is correct. > Is the pid used in any way when processing buildids? I can't think of any. The same DSO could conceivably be present in the virtual machine, the host, and in the workstation used for perf report. We just use the build-id in the perf.data file to find the right symtab. - Arnaldo