From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754046Ab2AaLe4 (ORCPT ); Tue, 31 Jan 2012 06:34:56 -0500 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:53744 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761Ab2AaLez (ORCPT ); Tue, 31 Jan 2012 06:34:55 -0500 Date: Tue, 31 Jan 2012 06:34:52 -0500 From: Christoph Hellwig To: Wu Fengguang Cc: Christoph Hellwig , Shaohua Li , lkml , linux-mm , Andrew Morton , Jens Axboe , Herbert Poetzl , Eric Dumazet , Vivek Goyal Subject: Re: [PATCH] fix readahead pipeline break caused by block plug Message-ID: <20120131113452.GA3235@infradead.org> References: <1327996780.21268.42.camel@sli10-conroe> <20120131103416.GA1661@localhost> <20120131104621.GA27003@infradead.org> <20120131105754.GA3867@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120131105754.GA3867@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2012 at 06:57:54PM +0800, Wu Fengguang wrote: > The problem is, there are a dozen of ->direct_IO callback functions. > While there are only two ->direct_IO() callers, one for READ and > another for WRITE, which are much easier to deal with. So what? Better do a bit more work now and keep the damn thing maintainable.