* [PATCH] xfs: show uuid when mount fails due to duplicate uuid
@ 2012-01-13 5:58 Mitsuo Hayasaka
2012-01-24 18:02 ` Christoph Hellwig
2012-01-31 19:19 ` Ben Myers
0 siblings, 2 replies; 3+ messages in thread
From: Mitsuo Hayasaka @ 2012-01-13 5:58 UTC (permalink / raw)
To: Ben Myers, Alex Elder, Christoph Hellwig
Cc: xfs-masters, xfs, linux-kernel, yrl.pp-manager.tt,
Mitsuo Hayasaka, Ben Myers, Alex Elder, Christoph Hellwig
When a system tries to mount a filesystem (FS) using UUID, the xfs
returns -EINVAL and shows a message if a FS with the same UUID has
been already mounted. It is useful to output the duplicate UUID
with it.
Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Ben Myers <bpm@sgi.com>
Cc: Alex Elder <elder@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_mount.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index d06afbc..e07f852 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -158,7 +158,7 @@ xfs_uuid_mount(
out_duplicate:
mutex_unlock(&xfs_uuid_table_mutex);
- xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
+ xfs_warn(mp, "Filesystem has duplicate UUID %pU - can't mount", uuid);
return XFS_ERROR(EINVAL);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: show uuid when mount fails due to duplicate uuid
2012-01-13 5:58 [PATCH] xfs: show uuid when mount fails due to duplicate uuid Mitsuo Hayasaka
@ 2012-01-24 18:02 ` Christoph Hellwig
2012-01-31 19:19 ` Ben Myers
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2012-01-24 18:02 UTC (permalink / raw)
To: Mitsuo Hayasaka
Cc: Ben Myers, Alex Elder, Christoph Hellwig, Alex Elder,
linux-kernel, xfs, xfs-masters, yrl.pp-manager.tt
On Fri, Jan 13, 2012 at 02:58:39PM +0900, Mitsuo Hayasaka wrote:
> When a system tries to mount a filesystem (FS) using UUID, the xfs
> returns -EINVAL and shows a message if a FS with the same UUID has
> been already mounted. It is useful to output the duplicate UUID
> with it.
The new version looks fine to me, thanks a lot!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: show uuid when mount fails due to duplicate uuid
2012-01-13 5:58 [PATCH] xfs: show uuid when mount fails due to duplicate uuid Mitsuo Hayasaka
2012-01-24 18:02 ` Christoph Hellwig
@ 2012-01-31 19:19 ` Ben Myers
1 sibling, 0 replies; 3+ messages in thread
From: Ben Myers @ 2012-01-31 19:19 UTC (permalink / raw)
To: Mitsuo Hayasaka
Cc: Alex Elder, Christoph Hellwig, Alex Elder, linux-kernel, xfs,
xfs-masters, yrl.pp-manager.tt
On Fri, Jan 13, 2012 at 02:58:39PM +0900, Mitsuo Hayasaka wrote:
> When a system tries to mount a filesystem (FS) using UUID, the xfs
> returns -EINVAL and shows a message if a FS with the same UUID has
> been already mounted. It is useful to output the duplicate UUID
> with it.
>
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Ben Myers <bpm@sgi.com>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-31 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-13 5:58 [PATCH] xfs: show uuid when mount fails due to duplicate uuid Mitsuo Hayasaka
2012-01-24 18:02 ` Christoph Hellwig
2012-01-31 19:19 ` Ben Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox