From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756849Ab2BATyN (ORCPT ); Wed, 1 Feb 2012 14:54:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50636 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756517Ab2BATyJ (ORCPT ); Wed, 1 Feb 2012 14:54:09 -0500 Date: Wed, 1 Feb 2012 11:54:03 -0800 From: Andrew Morton To: Frederic Weisbecker Cc: LKML Subject: Re: [PATCH] selftests: Make run_tests executable Message-Id: <20120201115403.d140742e.akpm@linux-foundation.org> In-Reply-To: <20120201152447.GC6731@somewhere.redhat.com> References: <1327943069-28048-1-git-send-email-fweisbec@gmail.com> <20120130155105.029b02fb.akpm@linux-foundation.org> <20120201152447.GC6731@somewhere.redhat.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Feb 2012 16:24:53 +0100 Frederic Weisbecker wrote: > On Mon, Jan 30, 2012 at 03:51:05PM -0800, Andrew Morton wrote: > > On Mon, 30 Jan 2012 18:04:29 +0100 > > Frederic Weisbecker wrote: > > > > > Make the main script that launches the tests to > > > become executable. Otherwise people need to launch > > > it as an argument to a new bash instance. > > > > > > > That's a feature ;) > > > > The x bit can easily get lost on kernel scripts. For example, if > > someone upgrades their kernel with patch(1) and the patch adds or > > renames the script, the x bit gets lost. > > > > If we were to set the x bit for the subset of people who get their > > scripts direct from a git repository then those people might write and > > distribute tools which fail when used by people who have lost their x > > bit. I've seen this happen at least once before. > > > > I see. Another way could be to chmod the run_test script from the Makefile. > Would that sound clumsy? I suggest we remove the script and make it a makefile target instead. "make tests" or whatever. As a microbonus that would remove the need to duplicate the TARGETS definition in the two scripts.