* namespaces: Out-of-bounds array access
@ 2012-01-06 0:18 Richard Weinberger
2012-02-01 23:21 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Richard Weinberger @ 2012-01-06 0:18 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: daniel.lezcano, linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
Hi!
While searching a completely different bug I've found this problem:
If CONFIG_NET_NS, CONFIG_UTS_NS and CONFIG_IPC_NS are disabled, ns_entries[]
becomes empty and things like ns_entries[ARRAY_SIZE(ns_entries) - 1] will explode.
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: namespaces: Out-of-bounds array access
2012-01-06 0:18 namespaces: Out-of-bounds array access Richard Weinberger
@ 2012-02-01 23:21 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2012-02-01 23:21 UTC (permalink / raw)
To: Richard Weinberger
Cc: Eric W. Biederman, daniel.lezcano, linux-kernel@vger.kernel.org
On Fri, 06 Jan 2012 01:18:47 +0100
Richard Weinberger <richard@nod.at> wrote:
> Hi!
>
> While searching a completely different bug I've found this problem:
> If CONFIG_NET_NS, CONFIG_UTS_NS and CONFIG_IPC_NS are disabled, ns_entries[]
> becomes empty and things like ns_entries[ARRAY_SIZE(ns_entries) - 1] will explode.
>
Presumably this will fix it:
--- a/fs/proc/namespaces.c~a
+++ a/fs/proc/namespaces.c
@@ -156,15 +156,15 @@ static struct dentry *proc_ns_dir_lookup
if (!ptrace_may_access(task, PTRACE_MODE_READ))
goto out;
- last = &ns_entries[ARRAY_SIZE(ns_entries) - 1];
- for (entry = ns_entries; entry <= last; entry++) {
+ last = &ns_entries[ARRAY_SIZE(ns_entries)];
+ for (entry = ns_entries; entry < last; entry++) {
if (strlen((*entry)->name) != len)
continue;
if (!memcmp(dentry->d_name.name, (*entry)->name, len))
break;
}
error = ERR_PTR(-ENOENT);
- if (entry > last)
+ if (entry == last)
goto out;
error = proc_ns_instantiate(dir, dentry, task, *entry);
_
But I wonder why we compile this file at all when ns_entries[] is
empty?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-01 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-06 0:18 namespaces: Out-of-bounds array access Richard Weinberger
2012-02-01 23:21 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).