From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
linus.walleij@stericsson.com, jedu@slimlogic.co.uk,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com,
sameo@linux.intel.com, gg@slimlogic.co.uk,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH V2] gpio: tps65910: Add sleep control support
Date: Wed, 1 Feb 2012 17:15:08 -0700 [thread overview]
Message-ID: <20120202001508.GD15343@ponder.secretlab.ca> (raw)
In-Reply-To: <CACRpkdbNxTe928p=7XdZVbqqfC5k0s1fqE=8DNa5zmg40pjwrQ@mail.gmail.com>
On Wed, Feb 01, 2012 at 01:30:54PM +0100, Linus Walleij wrote:
> On Wed, Feb 1, 2012 at 7:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
> > The device tps65910/tps65911 supports the sleep
> > functionality in some of gpios. If gpio is configured
> > in output mode and sleep is enabled then during device
> > sleep state, the output of gpio becomes LOW regardless
> > of non-sleep output value.
> > Such gpio can be used to control regulator switch such
> > that output of regulator is off in device sleep state.
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> > ---
> > Changes from V1:
> > Taken care of review comments from Linus Walleij's
> > - Remove magic numbers and added macro for defining them.
> > - Used bool type for the platform's gpio sleep control data.
>
> Thanks, looks good!
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
prev parent reply other threads:[~2012-02-02 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 6:39 [PATCH V2] gpio: tps65910: Add sleep control support Laxman Dewangan
2012-02-01 12:30 ` Linus Walleij
2012-02-02 0:15 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202001508.GD15343@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=jedu@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).