From: Frederic Weisbecker <fweisbec@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Paul Menage <paul@paulmenage.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Aditya Kali <adityakali@google.com>,
Oleg Nesterov <oleg@redhat.com>, Tim Hockin <thockin@hockin.org>,
Containers <containers@lists.linux-foundation.org>,
Glauber Costa <glommer@gmail.com>,
Cgroups <cgroups@vger.kernel.org>,
Daniel J Walsh <dwalsh@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Max Kellermann <mk@cm4all.com>,
Mandeep Singh Baines <msb@chromium.org>
Subject: Re: [PATCH 00/10] cgroups: Task counter subsystem v8
Date: Thu, 2 Feb 2012 15:50:02 +0100 [thread overview]
Message-ID: <20120202145000.GC9071@somewhere.redhat.com> (raw)
In-Reply-To: <20120201115107.93e11471.akpm@linux-foundation.org>
On Wed, Feb 01, 2012 at 11:51:07AM -0800, Andrew Morton wrote:
> On Wed, 1 Feb 2012 19:50:01 +0100
> Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > On Wed, Feb 01, 2012 at 08:31:26AM -0800, Tejun Heo wrote:
> > > On Wed, Feb 01, 2012 at 04:37:40AM +0100, Frederic Weisbecker wrote:
> > > > Changes In this version:
> > > >
> > > > - Split 32/64 bits version of res_counter_write_u64() [1/10]
> > > > Courtesy of Kirill A. Shutemov
> > > >
> > > > - Added Kirill's ack [8/10]
> > > >
> > > > - Added selftests [9/10], [10/10]
> > > >
> > > > Please consider for merging. At least two users want this feature:
> > >
> > > Has there been further discussion about this approach? IIRC, we
> > > weren't sure whether this should be merged.
> >
> > The doubts I have noticed were:
> >
> > Q: Can't we rather focus on a global solution to fight forkbombs?
> >
> > If we can find a reliable solution that works in any case and that
> > prevent from any forkbomb to impact the rest of the system then it
> > may be an acceptable solution. But I'm not aware of such feature.
> >
> > Besides, another point in having this task counter is that we
> > have a per container limit. Assuming all containers are running under
> > the same user, we can protect against a container starving all others
> > with a massive amount of processes close to the NR_PROC rlimit.
> >
> > Q: Can/should we implement a limitation on the number of "fork" as well?
> > (as in https://lkml.org/lkml/2011/11/3/233 )
> >
> > I'm still not sure about why such a thing is needed. Is it really something we
> > want? Why can't the task counter be used instead?
> >
> > I need more details from the author of this patch. But I doubt we can merge
> > both subsystems, they have pretty different semantics.
>
> What I struggle with is "is this feature useful enough to warrant
> merging it"?
The reason why I've been working on it is because we need this feature
(at least) for LXC.
Two people from our teams have jumped onto the discussion to express
that they want this feature and why:
https://lkml.org/lkml/2011/12/13/309
https://lkml.org/lkml/2011/12/13/364
next prev parent reply other threads:[~2012-02-02 14:50 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 3:37 [PATCH 00/10] cgroups: Task counter subsystem v8 Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 01/10] cgroups: add res_counter_write_u64() API Frederic Weisbecker
2012-02-02 12:33 ` Kirill A. Shutemov
2012-02-02 13:56 ` Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 02/10] cgroups: new resource counter inheritance API Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 03/10] cgroups: ability to stop res charge propagation on bounded ancestor Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 04/10] cgroups: add res counter common ancestor searching Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 05/10] res_counter: allow charge failure pointer to be null Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 06/10] cgroups: pull up res counter charge failure interpretation to caller Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 07/10] cgroups: allow subsystems to cancel a fork Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 08/10] cgroups: Add a task counter subsystem Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 09/10] selftests: Enter each directories before executing selftests Frederic Weisbecker
2012-02-01 3:37 ` [PATCH 10/10] selftests: Add a new task counter selftest Frederic Weisbecker
2012-02-01 16:31 ` [PATCH 00/10] cgroups: Task counter subsystem v8 Tejun Heo
2012-02-01 18:50 ` Frederic Weisbecker
2012-02-01 19:51 ` Andrew Morton
2012-02-02 14:50 ` Frederic Weisbecker [this message]
2012-02-16 15:31 ` Frederic Weisbecker
2012-03-01 22:53 ` Daniel Lezcano
2012-03-05 3:21 ` Frederic Weisbecker
2012-03-05 16:26 ` Tejun Heo
2012-03-05 16:27 ` Tejun Heo
2012-03-05 16:48 ` Frederic Weisbecker
2012-03-05 16:44 ` Rik van Riel
2013-04-01 18:43 ` Tim Hockin
2013-04-01 18:46 ` Tejun Heo
2013-04-01 20:09 ` Tim Hockin
2013-04-01 20:29 ` Tejun Heo
2013-04-01 21:02 ` Tim Hockin
2013-04-01 22:03 ` Tejun Heo
2013-04-01 22:20 ` Tim Hockin
2013-04-01 22:35 ` Tejun Heo
2013-04-01 22:57 ` Tim Hockin
2013-04-01 23:18 ` Tejun Heo
2013-04-02 0:07 ` Tim Hockin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202145000.GC9071@somewhere.redhat.com \
--to=fweisbec@gmail.com \
--cc=adityakali@google.com \
--cc=akpm@linux-foundation.org \
--cc=berrange@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=dwalsh@redhat.com \
--cc=glommer@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mk@cm4all.com \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
--cc=thockin@hockin.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).