From: Christoph Hellwig <hch@infradead.org>
To: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <aelder@sgi.com>,
Christoph Hellwig <hch@lst.de>, Alex Elder <elder@kernel.org>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
xfs-masters@oss.sgi.com, yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH 3/3] xfs: cleanup quota check on disk blocks and inodes reservations
Date: Thu, 2 Feb 2012 11:07:26 -0500 [thread overview]
Message-ID: <20120202160726.GA10568@infradead.org> (raw)
In-Reply-To: <20120123034543.3339.56848.stgit@ltc219.sdl.hitachi.co.jp>
On Mon, Jan 23, 2012 at 12:45:43PM +0900, Mitsuo Hayasaka wrote:
> This patch is a cleanup of quota check on disk blocks and inodes
> reservations.
>
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
> Cc: Ben Myers <bpm@sgi.com>
> Cc: Alex Elder <elder@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> ---
>
> fs/xfs/xfs_trans_dquot.c | 17 +++++++----------
> 1 files changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> index c4ba366..5e6cd1c 100644
> --- a/fs/xfs/xfs_trans_dquot.c
> +++ b/fs/xfs/xfs_trans_dquot.c
> @@ -605,7 +605,7 @@ xfs_trans_dqresv(
> time_t timer;
> xfs_qwarncnt_t warns;
> xfs_qwarncnt_t warnlimit;
> - xfs_qcnt_t count;
> + xfs_qcnt_t tcount;
Can you call this variable total_count to make it a bit more obvious?
> + tcount = *resbcountp + nblks;
> + if (hardlimit > 0ULL && tcount > hardlimit) {
Given that xfs_qcnt_t is unsigned what about transforming this into the
more readable:
if (hardlimit && total_count > hardlimit)
and similar for the others?
next prev parent reply other threads:[~2012-02-02 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 3:45 [PATCH 0/3] xfs: change available ranges in quota check Mitsuo Hayasaka
2012-01-23 3:45 ` [PATCH 1/3] xfs: consider new reservation for quota check on inode reservation Mitsuo Hayasaka
2012-01-23 3:45 ` [PATCH 2/3] xfs: change available ranges of softlimit and hardlimit in quota check Mitsuo Hayasaka
2012-01-23 3:45 ` [PATCH 3/3] xfs: cleanup quota check on disk blocks and inodes reservations Mitsuo Hayasaka
2012-02-02 16:07 ` Christoph Hellwig [this message]
2012-02-03 4:05 ` HAYASAKA Mitsuo
2012-01-24 17:46 ` [PATCH 0/3] xfs: change available ranges in quota check Christoph Hellwig
2012-01-27 6:21 ` HAYASAKA Mitsuo
2012-01-27 11:02 ` Christoph Hellwig
2012-01-27 14:02 ` HAYASAKA Mitsuo
2012-01-27 14:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202160726.GA10568@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=bpm@sgi.com \
--cc=elder@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mitsuo.hayasaka.hu@hitachi.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox