From: Andrew Morton <akpm@linux-foundation.org>
To: Corey Minyard <cminyard@mvista.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH 2/6] ipmi: Increase KCS timeouts
Date: Fri, 3 Feb 2012 11:50:26 -0800 [thread overview]
Message-ID: <20120203115026.9e2a357f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1328284079-5489-2-git-send-email-cminyard@mvista.com>
On Fri, 03 Feb 2012 09:47:55 -0600
Corey Minyard <cminyard@mvista.com> wrote:
> From: Matthew Garrett <mjg@redhat.com>
>
> We currently time out and retry KCS transactions after 1 second of waiting
> for IBF or OBF. This appears to be too short for some hardware. The IPMI
> spec says "All system software wait loops should include error timeouts. For
> simplicity, such timeouts are not shown explicitly in the flow diagrams. A
> five-second timeout or greater is recommended". Change the timeout to five
> seconds to satisfy the slow hardware.
Several of these patches fix bugs/problems, but there isn't enough info
here for me to decide whether we should patch 3.3 or earlier kernels.
I'm assuming "3.4 only".
> From: Matthew Garrett <mjg@redhat.com>
A dupe. The first one was correct.
next prev parent reply other threads:[~2012-02-03 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 15:47 [PATCH 1/6] ipmi: decreases the IPMI message transaction time in interrupt mode Corey Minyard
2012-02-03 15:47 ` [PATCH 2/6] ipmi: Increase KCS timeouts Corey Minyard
2012-02-03 19:50 ` Andrew Morton [this message]
2012-02-03 15:47 ` [PATCH 3/6] ipmi: use a tasklet for handling received messages Corey Minyard
2012-02-03 19:44 ` Andrew Morton
2012-02-03 20:01 ` Corey Minyard
2012-02-03 15:47 ` [PATCH 4/6] ipmi: Fix message handling during panics Corey Minyard
2012-02-03 15:47 ` [PATCH 5/6] ipmi: Simplify locking Corey Minyard
2012-02-03 15:47 ` [PATCH 6/6] ipmi: Use locks on watchdog timeout set on reboot Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120203115026.9e2a357f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox