From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755675Ab2BCPyw (ORCPT ); Fri, 3 Feb 2012 10:54:52 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37654 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290Ab2BCPyq (ORCPT ); Fri, 3 Feb 2012 10:54:46 -0500 X-Sasl-enc: IKmBNJTlfzg2YNTiv8LWz3gaPxgq/jyEEqsK8TsJK4aO 1328284485 Date: Fri, 3 Feb 2012 07:53:49 -0800 From: Greg KH To: Cong Wang Cc: linux-kernel@vger.kernel.org, Andrew Morton , Paul Gortmaker , Alan Cox , Jamie Iles , Stephen Warren , linux-serial@vger.kernel.org Subject: Re: [Patch] tty: fix a build failure on sparc Message-ID: <20120203155349.GC20638@kroah.com> References: <1328246540-5824-1-git-send-email-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1328246540-5824-1-git-send-email-xiyou.wangcong@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2012 at 01:22:10PM +0800, Cong Wang wrote: > On sparc, there is a build failure: > > drivers/tty/serial/8250/8250.c:48:21: error: suncore.h: No such file or directory > drivers/tty/serial/8250/8250.c:3275: error: implicit declaration of function 'sunserial_register_minors' > drivers/tty/serial/8250/8250.c:3305: error: implicit declaration of function 'sunserial_unregister_minors' > > this is due to commit 9bef3d4197379a995fa80f81950bbbf8d32e9e8b > (serial: group all the 8250 related code together) moved these files > into 8250/ subdirectory, but forgot to change the reference > to drivers/tty/serial/suncore.h. Ah, thanks, I'll go queue this up, sorry for the problem. greg k-h