Re: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning

Ingo Molnar
2012-02-05T11:39:11Z

* Joe Perches <joe@perches.com> wrote:

> + $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) {
> + if ($length > $max_line_len_strict) {
> + CHK("LONG_LINE",
> + "line over $max_line_len_strict characters\n" . $herecurr);
> + }
> + if ($length > $max_line_len_warn) {
> + WARN("LONG_LINE",
> + "line over $max_line_len_warn characters\n" . $herecurr);
> + }

In practice patch submitters take warnings just as seriously.
If it is emitted by the default checkpatch run, it's acted
upon. That is the human behavior that is a given.

If warnings are often crap and should not be acted upon then
frankly, don't emit them by default.

I don't care *how* that warning is removed - whether it's
removed from checkpatch or just hidden from the default view -
but it needs to be removed or people like Pekka (or me) stop
using it.

Thanks,

Ingo