From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Oleg Nesterov" <oleg@redhat.com>,
"Arve Hjønnevåg" <arve@android.com>,
"KOSAKI Motohiro" <kosaki.motohiro@gmail.com>,
"San Mehat" <san@google.com>, "Colin Cross" <ccross@android.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 1/6] oom: Make find_lock_task_mm() sparse-aware
Date: Mon, 6 Feb 2012 22:59:09 +0400 [thread overview]
Message-ID: <20120206185909.GB7741@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20120206163542.GA10104@kroah.com>
On Mon, Feb 06, 2012 at 08:35:42AM -0800, Greg KH wrote:
[...]
> > -extern struct task_struct *find_lock_task_mm(struct task_struct *p);
> > +extern struct task_struct *__find_lock_task_mm(struct task_struct *p);
> > +
> > +#define find_lock_task_mm(p) \
> > +({ \
> > + struct task_struct *__ret; \
> > + \
> > + __cond_lock(&(p)->alloc_lock, __ret = __find_lock_task_mm(p)); \
> > + __ret; \
> > +})
>
> Please use the proper "do...while" style thing here for multi-line,
> complex #defines like the rest of the kernel does so that you don't end
> up debugging horrible problems later.
Unfortunately this isn't possible in this case. Unlike '({})' GCC
extension, do-while statement does not evaluate to a value, i.e.
'x = do { 123; } while (0);' is illegal.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2012-02-06 18:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 4:33 [PATCH] staging: android/lowmemorykiller: Don't grab tasklist_lock Anton Vorontsov
2012-02-02 12:54 ` Oleg Nesterov
2012-02-02 17:16 ` Anton Vorontsov
2012-02-03 0:03 ` [PATCH v3] " Anton Vorontsov
2012-02-03 16:36 ` Oleg Nesterov
2012-02-03 16:30 ` [PATCH] " Oleg Nesterov
2012-02-06 16:29 ` [PATCH 1/6] oom: Make find_lock_task_mm() sparse-aware Anton Vorontsov
2012-02-06 16:35 ` Greg KH
2012-02-06 18:59 ` Anton Vorontsov [this message]
2012-02-06 19:18 ` Greg KH
2012-02-06 21:27 ` KOSAKI Motohiro
2012-02-07 4:48 ` [PATCH v2 " Anton Vorontsov
2012-02-07 5:17 ` KOSAKI Motohiro
2012-02-08 15:27 ` Oleg Nesterov
2012-02-09 16:45 ` [PATCH] sched: Turn lock_task_sighand() into a static inline Anton Vorontsov
2012-02-11 23:10 ` [tip:sched/core] " tip-bot for Anton Vorontsov
2012-02-15 13:52 ` Peter Zijlstra
2012-02-06 16:29 ` [PATCH 2/6] oom: Get rid of sparse warnings Anton Vorontsov
2012-02-06 21:33 ` KOSAKI Motohiro
2012-02-07 4:20 ` [PATCH v2 " Anton Vorontsov
2012-02-07 5:38 ` KOSAKI Motohiro
2012-02-07 6:23 ` Anton Vorontsov
2012-02-08 18:13 ` KOSAKI Motohiro
2012-02-06 16:29 ` [PATCH 3/6] staging: android/lowmemorykiller: Don't grab tasklist_lock Anton Vorontsov
2012-02-06 16:36 ` Greg KH
2012-02-06 16:42 ` Anton Vorontsov
2012-02-09 0:56 ` Greg KH
2012-02-08 15:32 ` Oleg Nesterov
2012-02-06 16:29 ` [PATCH 4/6] staging: android/lowmemorykiller: Better mm handling Anton Vorontsov
2012-02-06 21:36 ` KOSAKI Motohiro
2012-02-08 15:34 ` Oleg Nesterov
2012-02-06 16:29 ` [PATCH 5/6] staging: android/lowmemorykiller: No need for task->signal check Anton Vorontsov
2012-02-06 21:38 ` KOSAKI Motohiro
2012-02-08 15:35 ` Oleg Nesterov
2012-02-06 16:30 ` [PATCH 6/6] staging: android/lowmemorykiller: Do not kill kernel threads Anton Vorontsov
2012-02-06 21:38 ` KOSAKI Motohiro
2012-02-08 15:36 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206185909.GB7741@oksana.dev.rtsoft.ru \
--to=anton.vorontsov@linaro.org \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).