[PATCH] staging: android/ram_console: Don't build on arches w/o ioremap

[PATCH] staging: android/ram_console: Don't build on arches w/o ioremap

[Anton Vorontsov]

This patch fixes UML build:

    CC      drivers/staging/android/ram_console.o
  drivers/staging/android/ram_console.c: In function
  'ram_console_driver_probe':
  drivers/staging/android/ram_console.c:358:2: error: implicit declaration
  of function 'ioremap' [-Werror=implicit-function-declaration]
  cc1: some warnings being treated as errors
  make[3]: *** [drivers/staging/android/ram_console.o] Error 1

Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
 drivers/staging/android/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index becf711..2054ccb 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -27,6 +27,7 @@ config ANDROID_LOGGER
 
 config ANDROID_RAM_CONSOLE
 	bool "Android RAM buffer console"
+	depends on !S390 && !UML
 	default n
 
 config ANDROID_RAM_CONSOLE_ENABLE_VERBOSE
-- 
1.7.7.6

Re: [PATCH] staging: android/ram_console: Don't build on arches w/o ioremap

[Geert Uytterhoeven]

On Tue, Feb 7, 2012 at 06:13, Anton Vorontsov
<anton.vorontsov@linaro.org> wrote:
> This patch fixes UML build:
>
>    CC      drivers/staging/android/ram_console.o
>  drivers/staging/android/ram_console.c: In function
>  'ram_console_driver_probe':
>  drivers/staging/android/ram_console.c:358:2: error: implicit declaration
>  of function 'ioremap' [-Werror=implicit-function-declaration]
>  cc1: some warnings being treated as errors
>  make[3]: *** [drivers/staging/android/ram_console.o] Error 1
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
> ---
>  drivers/staging/android/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index becf711..2054ccb 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -27,6 +27,7 @@ config ANDROID_LOGGER
>
>  config ANDROID_RAM_CONSOLE
>        bool "Android RAM buffer console"
> +       depends on !S390 && !UML

Shouldn't that be "depends on HAS_IOMEM" instead?
I guess it also break on tile, which is the third NO_IOMEM arch?

>        default n

Superfluous, "n" is the default.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds