linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Paul Mundt <lethal@linux-sh.org>,
	Russell King <linux@arm.linux.org.uk>,
	Mike Frysinger <vapier@gentoo.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] powerpc/mm: Fix possible race on task->mm
Date: Tue, 7 Feb 2012 10:50:22 +0400	[thread overview]
Message-ID: <20120207065022.GD1496@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20120207064809.GA29061@oksana.dev.rtsoft.ru>

Checking for task->mm is dangerous as ->mm might disappear (exit_mm()
assigns NULL under task_lock(), so tasklist lock is not enough).

We can't use get_task_mm()/mmput() pair as mmput() might sleep,
so let's take the task lock while we care about its mm.

Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
 arch/powerpc/mm/mmu_context_nohash.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/mm/mmu_context_nohash.c b/arch/powerpc/mm/mmu_context_nohash.c
index 5b63bd3..13ec484 100644
--- a/arch/powerpc/mm/mmu_context_nohash.c
+++ b/arch/powerpc/mm/mmu_context_nohash.c
@@ -43,6 +43,7 @@
 #include <linux/kernel.h>
 #include <linux/mm.h>
 #include <linux/init.h>
+#include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/bootmem.h>
 #include <linux/notifier.h>
@@ -360,8 +361,10 @@ static int __cpuinit mmu_context_cpu_notify(struct notifier_block *self,
 		/* We also clear the cpu_vm_mask bits of CPUs going away */
 		read_lock(&tasklist_lock);
 		for_each_process(p) {
+			task_lock(p);
 			if (p->mm)
 				cpumask_clear_cpu(cpu, mm_cpumask(p->mm));
+			task_unlock(p);
 		}
 		read_unlock(&tasklist_lock);
 	break;
-- 
1.7.7.6


  parent reply	other threads:[~2012-02-07  6:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07  6:48 [PATCH 0/8] Fixes for common mistakes w/ for_each_process and task->mm Anton Vorontsov
2012-02-07  6:49 ` [PATCH 1/8] sysrq: Fix possible race with exiting task Anton Vorontsov
2012-02-09  1:47   ` David Rientjes
2012-02-07  6:49 ` [PATCH 2/8] sysrq: Properly check for kernel threads Anton Vorontsov
2012-02-09  1:46   ` David Rientjes
2012-02-07  6:50 ` [PATCH 3/8] arm: Fix possible race on task->mm Anton Vorontsov
2012-02-08 16:08   ` Oleg Nesterov
2012-02-09 15:33     ` Anton Vorontsov
2012-02-09 15:43       ` Anton Vorontsov
2012-02-10 20:21         ` Oleg Nesterov
2012-02-09  1:46   ` David Rientjes
2012-02-07  6:50 ` Anton Vorontsov [this message]
2012-02-07  6:50 ` [PATCH 5/8] sh: " Anton Vorontsov
2012-02-07  6:50 ` [PATCH 6/8] blackfin: " Anton Vorontsov
2012-02-08 16:20   ` Oleg Nesterov
2012-02-07  6:51 ` [PATCH 7/8] um: Should hold tasklist_lock while traversing processes Anton Vorontsov
2012-02-07  6:51 ` [PATCH 8/8] um: Fix possible race on task->mm Anton Vorontsov
2012-02-08 15:59 ` [PATCH 0/8] Fixes for common mistakes w/ for_each_process and task->mm Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120207065022.GD1496@oksana.dev.rtsoft.ru \
    --to=anton.vorontsov@linaro.org \
    --cc=benh@kernel.crashing.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kosaki.motohiro@gmail.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=richard@nod.at \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).