From: Wolfram Sang <w.sang@pengutronix.de>
To: Austin Boyle <Austin.Boyle@aviatnet.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] rtc: ds1307: generalise ram size and offset
Date: Tue, 7 Feb 2012 15:56:52 +0100 [thread overview]
Message-ID: <20120207145652.GH2539@pengutronix.de> (raw)
In-Reply-To: <1328221704.3159.50.camel@pc786-ubu.gnet.global.vpn>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
> So if you have multiple RTCs, even of the same type, they would be in
> rtc0, rtc1, rtc2
>
> Since they each have their own nvram, does it matter if the size is
> changed?
Yes, because currently you pass a pointer to a static struct to the
sysfs_bin_attribute. If you change the size of the static struct to
another value, all other instances will get the new size, too, because
they still use the pointer to it.
You could just delete the size from the static struct, copy it over and
add the correct size to the copy and pass the copy to create_bin_file().
Or you initialize directly.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-07 14:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 21:21 [PATCH v3] rtc: ds1307: generalise ram size and offset Austin Boyle
2012-01-09 22:17 ` Wolfram Sang
2012-01-10 0:33 ` Austin Boyle
2012-01-11 11:06 ` Wolfram Sang
2012-01-11 22:21 ` Austin Boyle
2012-01-18 21:41 ` Wolfram Sang
2012-01-19 19:45 ` Wolfram Sang
2012-02-02 0:37 ` Austin Boyle
2012-02-02 14:53 ` [rtc-linux] " Wolfram Sang
2012-02-02 22:28 ` Austin Boyle
2012-02-07 14:56 ` Wolfram Sang [this message]
2012-02-07 21:45 ` Austin Boyle
2012-02-08 22:23 ` [PATCH v4] " Austin Boyle
2012-02-08 22:36 ` Andrew Morton
2012-02-13 14:36 ` Wolfram Sang
2012-02-14 4:23 ` Austin Boyle
2012-02-21 14:00 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2011-11-03 21:07 [PATCH v3] " Austin Boyle
2011-11-03 21:25 ` David Anders
2011-12-19 1:24 ` Austin Boyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207145652.GH2539@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=Austin.Boyle@aviatnet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).