From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
LKML <linux-kernel@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>
Subject: Re: perf: record segfaults for cycles event when collecting data on a VM
Date: Thu, 9 Feb 2012 08:30:24 +0100 [thread overview]
Message-ID: <20120209073024.GA18010@elte.hu> (raw)
In-Reply-To: <20120208175709.GK22598@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> > which makes sense. It forces
> > perf_session__find_machine_for_cpumode() to return the host
> > machine always.
>
> Great, thanks. I will send two patches tomorrow to fix Jason's
> problem and change the default for perf_guest.
Well, if the crash is fixed then the the default can stay,
right?
Generally we should treat all input data in a perf.data or even
the bits we get in the ring-buffer as external data that has to
be checked carefully, with no assumptions made about data.
Thanks,
Ingo
next prev parent reply other threads:[~2012-02-09 7:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:55 perf: record segfaults for cycles event when collecting data on a VM David Ahern
2012-02-08 17:44 ` Joerg Roedel
2012-02-08 17:53 ` David Ahern
2012-02-08 17:57 ` Joerg Roedel
2012-02-09 7:30 ` Ingo Molnar [this message]
2012-02-09 11:14 ` Joerg Roedel
2012-02-09 13:34 ` Ingo Molnar
2012-02-09 14:32 ` Joerg Roedel
2012-02-09 15:28 ` Joerg Roedel
2012-02-09 15:47 ` David Ahern
2012-02-09 14:43 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209073024.GA18010@elte.hu \
--to=mingo@elte.hu \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=jasowang@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox