public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
	"lrg@ti.com" <lrg@ti.com>,
	"jedu@slimlogic.co.uk" <jedu@slimlogic.co.uk>,
	"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V1 1/2] mfd: tps65910: use regmap for device register access.
Date: Thu, 9 Feb 2012 12:03:12 +0000	[thread overview]
Message-ID: <20120209120312.GE3058@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F33B52A.5020900@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On Thu, Feb 09, 2012 at 05:29:38PM +0530, Laxman Dewangan wrote:

> I am working on mfd/tps65910.c and function is:
> static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
>                                    int bytes, void *src)

> All your feedback will help me to improve my next two mfd/pmic
> drivers which I am planning to upstream...

Yeah, I know that's the i2c_write() function but all the callers I
noticed were calling it with bytes set to 1.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-02-09 12:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 10:46 [PATCH V1 1/2] mfd: tps65910: use regmap for device register access Laxman Dewangan
2012-02-08 10:46 ` [PATCH V1 2/2] regulator: tps65910: Enable register caching of voltage controls Laxman Dewangan
2012-02-08 11:41 ` [PATCH V1 1/2] mfd: tps65910: use regmap for device register access Mark Brown
2012-02-08 12:15   ` Laxman Dewangan
2012-02-08 13:07     ` Mark Brown
2012-02-08 13:34       ` Laxman Dewangan
2012-02-08 13:58         ` Mark Brown
2012-02-09  5:03           ` Laxman Dewangan
2012-02-09 11:55             ` Mark Brown
2012-02-09 11:59               ` Laxman Dewangan
2012-02-09 12:03                 ` Mark Brown [this message]
2012-02-09 12:09                   ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120209120312.GE3058@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=gg@slimlogic.co.uk \
    --cc=jedu@slimlogic.co.uk \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox