From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V1] regmap: add bulk_write() for non-volatile register set
Date: Thu, 9 Feb 2012 12:17:05 +0000 [thread overview]
Message-ID: <20120209121704.GF3058@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1328789531-10067-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
On Thu, Feb 09, 2012 at 05:42:11PM +0530, Laxman Dewangan wrote:
> + if (vol || map->cache_type == REGCACHE_NONE) {
> + ret = _regmap_raw_write(map, reg, val, val_bytes * val_count);
You still need to do the byte swap here.
> + } else {
> + for (i = 0; i < val_count; i++) {
> + memcpy(map->work_buf, val + (i * val_bytes), val_bytes);
> + ival = map->format.parse_val(map->work_buf);
They're currently symmetric but really this should use format_val().
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-09 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 12:12 [PATCH V1] regmap: add bulk_write() for non-volatile register set Laxman Dewangan
2012-02-09 12:17 ` Mark Brown [this message]
2012-02-09 12:45 ` Laxman Dewangan
2012-02-09 12:55 ` Mark Brown
2012-02-09 17:14 ` Laxman Dewangan
2012-02-09 18:12 ` Mark Brown
2012-02-10 9:13 ` Laxman Dewangan
2012-02-10 11:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209121704.GF3058@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@suse.de \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).