From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757430Ab2BIMRK (ORCPT ); Thu, 9 Feb 2012 07:17:10 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39274 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756035Ab2BIMRI (ORCPT ); Thu, 9 Feb 2012 07:17:08 -0500 Date: Thu, 9 Feb 2012 12:17:05 +0000 From: Mark Brown To: Laxman Dewangan Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH V1] regmap: add bulk_write() for non-volatile register set Message-ID: <20120209121704.GF3058@opensource.wolfsonmicro.com> References: <1328789531-10067-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JcvBIhDvR6w3jUPA" Content-Disposition: inline In-Reply-To: <1328789531-10067-1-git-send-email-ldewangan@nvidia.com> X-Cookie: You now have Asian Flu. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JcvBIhDvR6w3jUPA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 09, 2012 at 05:42:11PM +0530, Laxman Dewangan wrote: > + if (vol || map->cache_type == REGCACHE_NONE) { > + ret = _regmap_raw_write(map, reg, val, val_bytes * val_count); You still need to do the byte swap here. > + } else { > + for (i = 0; i < val_count; i++) { > + memcpy(map->work_buf, val + (i * val_bytes), val_bytes); > + ival = map->format.parse_val(map->work_buf); They're currently symmetric but really this should use format_val(). --JcvBIhDvR6w3jUPA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPM7k6AAoJEBus8iNuMP3dgPsP/3jT/jrYFN/09eJeErBEwOiY c/s70UB13MpFk/l6gNe6o0gVLhDZNEYIVSVc8lHXowhGQ6yzroLK4fGJ6bEqMx+p Pu5OT77Os4oGxuAdFcBJf5YHDZ1zgNV1xv8gyHotI0Xc2CqNoI6iyg4/svoleyy7 EJajaN/wa2Jmb4UprBR8/ic/GVOx60JQQc+kmIjF2R8gd2Rnc6FvApoFtBYeIpna jhCikWyfzm3t7Me5g0HSz+v5hNHrpf5UTjmiUoOEUXcoCkFPP3XaNNBsnQ/uRSWl hU5igkGMM34oZlNKBwmwXgNBrj4YCHeBVGcLqb+iEwfepj50nUKVtseK4RnW/W+Y JwOu8qhPzPHqgL0/rPM2qIdk6IJzCzXMlYC4P6mitMVP8OCB3xtDdjgsxhTVkV94 P7sHN2QWTv0Zcfhc8Vqq8rezXYytcLMrwYFAJQUwcGnIr0TKkQBZjuJHNiNLALW7 YSp9zZioYeb01UH9I3pGgPFTiIz9Gb9ut7kDmORA9sPDINRHzHd7qdePTq2D+pwa Gp6RbEQhZTeFrOr4mpk3sbuS7wZhC/w9w63d0NehCeAbl17bMqopQo+l/XtgfO+3 IairWyd/c7clU78hmrgGYOs4OXGastu7AVPWRgoGeBXVb7hQVBYgI2JBqM+QJ+po CaCsPlsX1qPtD7EC1uN5 =OqDE -----END PGP SIGNATURE----- --JcvBIhDvR6w3jUPA--