From: Don Zickus <dzickus@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
kexec-list <kexec@lists.infradead.org>
Subject: Re: [PATCH] x86, kdump: No need to disable ioapic in crash path
Date: Thu, 9 Feb 2012 09:48:57 -0500 [thread overview]
Message-ID: <20120209144857.GC5650@redhat.com> (raw)
In-Reply-To: <m1sjilc4vh.fsf@fess.ebiederm.org>
On Wed, Feb 08, 2012 at 02:55:14PM -0800, Eric W. Biederman wrote:
> > I ran lkdtm by panic'ing in the interrupt handle thus leaving device
> > interrupt un-ack'd and the apic might have been un-ack'd too (jprobes
> > hooked in at do_IRQ). 3 out 3 times the second kernel came up on my core2
> > quad.
>
> That sounds like more than enough basic testing for me. Document your
> testing in a patch description and let's get the unnecessary local apic
> and ioapic stomping removed from the kexec on panic path.
>
> There were bugs. We deleted the code that had them. The bugs are gone
> and there are no new problems goes over very well in my book.
Great. Thanks. I'll put together the patch.
Cheers,
Don
next prev parent reply other threads:[~2012-02-09 14:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 18:12 [PATCH] x86, kdump: No need to disable ioapic in crash path Don Zickus
2012-02-02 23:24 ` Eric W. Biederman
2012-02-07 21:57 ` Don Zickus
2012-02-07 22:19 ` Vivek Goyal
2012-02-07 23:35 ` Eric W. Biederman
2012-02-08 20:11 ` Don Zickus
2012-02-08 22:55 ` Eric W. Biederman
2012-02-09 14:48 ` Don Zickus [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-29 20:08 Don Zickus
2012-03-15 20:26 ` Don Zickus
2012-03-15 21:16 ` Seiji Aguchi
2012-03-15 21:33 ` Don Zickus
2012-03-15 21:37 ` Seiji Aguchi
2012-04-30 20:53 ` Don Zickus
2012-05-02 19:10 ` Seiji Aguchi
2012-05-02 19:39 ` Eric W. Biederman
2012-05-02 19:59 ` Don Zickus
2012-05-02 20:24 ` Eric W. Biederman
2012-03-29 16:02 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209144857.GC5650@redhat.com \
--to=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).