* [PATCH] Fix mc13xxx regulator build on sparc64
@ 2012-02-09 21:43 David Miller
2012-02-09 21:52 ` Al Viro
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Miller @ 2012-02-09 21:43 UTC (permalink / raw)
To: shawn.guo; +Cc: linux-kernel, broonie
Since mc13xxx-regulator-core.c and the actual drivers can get built
into seperate modules, you have to export the DT support symbols
"mc13xxx_get_num_regulators_dt" and "mc13xxx_parse_regulators_dt"
otherwise the allmodconfig build fails on sparc64.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/regulator/mc13xxx-regulator-core.c b/drivers/regulator/mc13xxx-regulator-core.c
index 80ecafe..62dcd0a 100644
--- a/drivers/regulator/mc13xxx-regulator-core.c
+++ b/drivers/regulator/mc13xxx-regulator-core.c
@@ -254,6 +254,7 @@ int __devinit mc13xxx_get_num_regulators_dt(struct platform_device *pdev)
return num;
}
+EXPORT_SYMBOL_GPL(mc13xxx_get_num_regulators_dt);
struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
struct platform_device *pdev, struct mc13xxx_regulator *regulators,
@@ -291,6 +292,7 @@ struct mc13xxx_regulator_init_data * __devinit mc13xxx_parse_regulators_dt(
return data;
}
+EXPORT_SYMBOL_GPL(mc13xxx_parse_regulators_dt);
#endif
MODULE_LICENSE("GPL v2");
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix mc13xxx regulator build on sparc64
2012-02-09 21:43 [PATCH] Fix mc13xxx regulator build on sparc64 David Miller
@ 2012-02-09 21:52 ` Al Viro
2012-02-09 22:09 ` Mark Brown
2012-02-09 23:03 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2012-02-09 21:52 UTC (permalink / raw)
To: David Miller; +Cc: shawn.guo, linux-kernel, broonie
On Thu, Feb 09, 2012 at 04:43:01PM -0500, David Miller wrote:
>
> Since mc13xxx-regulator-core.c and the actual drivers can get built
> into seperate modules, you have to export the DT support symbols
> "mc13xxx_get_num_regulators_dt" and "mc13xxx_parse_regulators_dt"
> otherwise the allmodconfig build fails on sparc64.
... and not just sparc, either - i386 allmodconfig and powerpc ones run into
the same thing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix mc13xxx regulator build on sparc64
2012-02-09 21:43 [PATCH] Fix mc13xxx regulator build on sparc64 David Miller
2012-02-09 21:52 ` Al Viro
@ 2012-02-09 22:09 ` Mark Brown
2012-02-09 23:03 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-02-09 22:09 UTC (permalink / raw)
To: David Miller; +Cc: shawn.guo, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On Thu, Feb 09, 2012 at 04:43:01PM -0500, David Miller wrote:
> Since mc13xxx-regulator-core.c and the actual drivers can get built
> into seperate modules, you have to export the DT support symbols
> "mc13xxx_get_num_regulators_dt" and "mc13xxx_parse_regulators_dt"
> otherwise the allmodconfig build fails on sparc64.
Hrm, this was reported in -next and fixed with commit 234393 (regulator:
mc13xxx-regulator-core: Fix the build when driver is selected as module)
but didn't get reported when the commit was first introduced...
Given that allmodconfigs are one of the most commonly tested
configurations for -next I'm wondering both why this didn't get picked
up by any of them and why this is a sparc64 specific issue?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix mc13xxx regulator build on sparc64
2012-02-09 21:43 [PATCH] Fix mc13xxx regulator build on sparc64 David Miller
2012-02-09 21:52 ` Al Viro
2012-02-09 22:09 ` Mark Brown
@ 2012-02-09 23:03 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-02-09 23:03 UTC (permalink / raw)
To: David Miller; +Cc: shawn.guo, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 372 bytes --]
On Thu, Feb 09, 2012 at 04:43:01PM -0500, David Miller wrote:
> Since mc13xxx-regulator-core.c and the actual drivers can get built
> into seperate modules, you have to export the DT support symbols
> "mc13xxx_get_num_regulators_dt" and "mc13xxx_parse_regulators_dt"
> otherwise the allmodconfig build fails on sparc64.
Applied with a little changelog fettling, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-09 23:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 21:43 [PATCH] Fix mc13xxx regulator build on sparc64 David Miller
2012-02-09 21:52 ` Al Viro
2012-02-09 22:09 ` Mark Brown
2012-02-09 23:03 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).