From: Ingo Molnar <mingo@elte.hu>
To: David Ahern <dsahern@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
x86@kernel.org
Subject: Re: Hmm.. WARN_ON_ONCE(cpuc->enabled)
Date: Fri, 10 Feb 2012 07:10:46 +0100 [thread overview]
Message-ID: <20120210061046.GA21805@elte.hu> (raw)
In-Reply-To: <4F346111.1040506@gmail.com>
* David Ahern <dsahern@gmail.com> wrote:
> On 02/09/2012 04:46 PM, Linus Torvalds wrote:
> > Ok, so I get the appended on my Core i5 when I did a "perf record -f
> > -e cycles:pp make -j" on the kernel build.
> >
> > What's up, guys? I haven't tried that particular perf run in a while,
> > so it might have been going on for quite some time.
>
> Perhaps already fixed by
> https://lkml.org/lkml/2012/2/4/42
>
> It's not in your tree; but in tip/urgent.
That patch only fixed the symptom - there was an underlying bug
that is fixed in perf/urgent as well, via:
f39d47ff819e: perf: Fix double start/stop in x86_pmu_start()
I committed it two days ago - so it narrowly missed -rc3. Note
that no actual misbehavior is known to be caused by this bug,
beyond the annoying WARN_ONCE() messages and a potential slight
mis-measurement.
I'll send those fixes to Linus in a couple of hours.
Thanks,
Ingo
prev parent reply other threads:[~2012-02-10 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 23:46 Hmm.. WARN_ON_ONCE(cpuc->enabled) Linus Torvalds
2012-02-10 0:13 ` David Ahern
2012-02-10 6:10 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210061046.GA21805@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).