Re: [PATCH 7/9] PCI: Make pci bridge reallocating enabled/disabled

[Jesse Barnes <jbarnes@virtuousgeek.org>]

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

On Sat,  4 Feb 2012 22:55:06 -0800
Yinghai Lu <yinghai@kernel.org> wrote:

> Let the user could enable and disable with pci=realloc=on or pci=realloc=off
> 
> Also
> 1. move variable and functions near the place they are used.
> 2. change macro to function
> 3. change related functions and variable to static and _init
> 4. update parameter description accordingly.
> 
> -v2: still honor pci=realloc, and treat it as pci=realloc=on
>      also use enum instead of ...
> 
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> ---
>  Documentation/kernel-parameters.txt |    8 ++++++--
>  drivers/pci/pci.c                   |    4 +++-
>  drivers/pci/pci.h                   |    2 +-
>  drivers/pci/setup-bus.c             |   33 ++++++++++++++++++++++++++-------
>  4 files changed, 36 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 033d4e6..e11e5dd 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -2109,8 +2109,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
>  				the default.
>  				off: Turn ECRC off
>  				on: Turn ECRC on.
> -		realloc		reallocate PCI resources if allocations done by BIOS
> -				are erroneous.
> +		realloc=	Enable/disable reallocating PCI bridge resources
> +				if allocations done by BIOS are too small to fit
> +				resources required by children devices.
> +				off: Turn realloc off
> +				on: Turn realloc on
> +		realloc		same as realloc=on

"too small to accommodate resources required by all child devices"

Looks good otherwise.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]