linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	dzickus@redhat.com, seiji.aguchi@hds.com
Subject: Re: [PATCH] kmsg_dump: Don't run on non-error paths by default
Date: Fri, 10 Feb 2012 10:44:53 -0500	[thread overview]
Message-ID: <20120210154453.GA3150@redhat.com> (raw)
In-Reply-To: <1328886693-20670-1-git-send-email-mjg@redhat.com>

On Fri, Feb 10, 2012 at 10:11:33AM -0500, Matthew Garrett wrote:

[..]
>  static int have_callable_console(void)
>  {
> @@ -1732,6 +1735,9 @@ void kmsg_dump(enum kmsg_dump_reason reason)
>  	unsigned long l1, l2;
>  	unsigned long flags;
>  
> +	if (reason > KMSG_DUMP_PANIC && !always_kmsg_dump)
> +		return;
> +

reason > KMSG_DUMP_OOPS?

Thanks
Vivek

  parent reply	other threads:[~2012-02-10 15:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 15:11 [PATCH] kmsg_dump: Don't run on non-error paths by default Matthew Garrett
2012-02-10 15:36 ` Jack Stone
2012-02-10 15:44   ` Matthew Garrett
2012-02-10 15:44 ` Vivek Goyal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-02-08 16:14 Matthew Garrett
2012-02-08 16:30 ` Vivek Goyal
2012-02-08 16:37   ` Matthew Garrett
2012-02-08 16:44     ` Vivek Goyal
2012-02-08 20:24 ` Seiji Aguchi
     [not found] ` <32727E9A83EE9A42A1F0906295A3A77B2E598C0A2F@USINDEVS01.corp.hds.com>
2012-02-08 20:26   ` Seiji Aguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120210154453.GA3150@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=seiji.aguchi@hds.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).