From: Don Zickus <dzickus@redhat.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"seiji.aguchi@hds.com" <seiji.aguchi@hds.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"mjg@redhat.com" <mjg@redhat.com>,
"levinsasha928@gmail.com" <levinsasha928@gmail.com>
Subject: Re: [PATCH 2/2] x86, reschedule: check to see if system is shutting down
Date: Fri, 10 Feb 2012 17:53:31 -0500 [thread overview]
Message-ID: <20120210225331.GO5650@redhat.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F03AA72@ORSMSX104.amr.corp.intel.com>
On Fri, Feb 10, 2012 at 10:42:24PM +0000, Luck, Tony wrote:
> - WARN_ON(1);
> + if (atomic_read(&stopping_cpu) == -1)
> + /* system is not shutting down.. yell */
> + WARN_ON(1);
>
> Should that be written as:
>
> /* system is not shutting down.. yell */
> WARN_ON(atomic_read(&stopping_cpu) == -1);
>
> the
> if (something)
> WARN_ON(1);
>
> looks weird.
Indeed. In my haste, I wrote some pretty sloppy code.
Thanks for catching that.
Cheers,
Don
next prev parent reply other threads:[~2012-02-10 22:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 21:02 [PATCH 0/2] x86, reboot: cleanup NMI and REBOOT_IRQ Don Zickus
2012-02-10 21:02 ` [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
2012-02-10 21:02 ` [PATCH 2/2] x86, reschedule: check to see if system is shutting down Don Zickus
2012-02-10 22:42 ` Luck, Tony
2012-02-10 22:53 ` Don Zickus [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-13 20:27 [PATCH 0/2 v2] x86, reboot: cleanup NMI and REBOOT_IRQ Don Zickus
2012-02-13 20:27 ` [PATCH 2/2] x86, reschedule: check to see if system is shutting down Don Zickus
2012-02-13 21:22 ` Seiji Aguchi
2012-02-13 22:43 ` Don Zickus
2012-02-15 11:26 ` Peter Zijlstra
2012-02-15 14:54 ` Don Zickus
2012-02-15 14:57 ` Peter Zijlstra
2012-02-15 15:57 ` Don Zickus
2012-02-15 17:59 ` Peter Zijlstra
2012-02-16 3:14 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210225331.GO5650@redhat.com \
--to=dzickus@redhat.com \
--cc=ak@linux.intel.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=peterz@infradead.org \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).