From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756380Ab2BMJVh (ORCPT ); Mon, 13 Feb 2012 04:21:37 -0500 Received: from s15943758.onlinehome-server.info ([217.160.130.188]:56834 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756240Ab2BMJVg (ORCPT ); Mon, 13 Feb 2012 04:21:36 -0500 Date: Mon, 13 Feb 2012 10:21:31 +0100 From: Borislav Petkov To: Mauro Carvalho Chehab Cc: Borislav Petkov , Linux Edac Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH v3 01/31] events/hw_event: Create a Hardware Events Report Mecanism (HERM) Message-ID: <20120213092131.GA7235@aftab> References: <1328832090-9166-1-git-send-email-mchehab@redhat.com> <1328832090-9166-2-git-send-email-mchehab@redhat.com> <20120210134115.GC16783@aftab> <4F35270F.1020402@redhat.com> <20120212124825.GC32467@aftab> <4F37F526.8090907@redhat.com> <20120212184445.GA2080@aftab> <4F381520.8070504@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F381520.8070504@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 12, 2012 at 05:38:08PM -0200, Mauro Carvalho Chehab wrote: > Em 12-02-2012 16:44, Borislav Petkov escreveu: > > On Sun, Feb 12, 2012 at 03:21:42PM -0200, Mauro Carvalho Chehab wrote: > >> As I said before, there's just one trace call for memory error events > >> (hw_event:mc_error) on my second RFC. > > > > Are you kidding me: > > > > $ grep -EriIno "trace_.*\W" patch01.txt > > > > ... > > > > TRACE_EVENT(mc_corrected_error, > > TRACE_EVENT(mc_uncorrected_error, > > TRACE_EVENT(mc_corrected_error_fbd, > > TRACE_EVENT(mc_uncorrected_error_fbd, > > TRACE_EVENT(mc_out_of_range, > > TRACE_EVENT(mc_corrected_error_no_info, > > TRACE_EVENT(mc_uncorrected_error_no_info, > > > > Huh? > > See PATCH v3 03/31: hw_event: Consolidate uncorrected/corrected error msgs into one > > Those events got merged there into one hardware event and one > software error event generated due to a hardware trouble > (mc_out_of_range). [..] Right, and what I was suggesting is to introduce a single trace event and use it everywhere. Instead, you're converting the edac calls into trace events and then eliminating them, which creates unnecessary noise. But, nevermind this, I have a better suggestion: instead of you and me going back and forth needlessly about the trace events, how about you concentrate on fixing the FBDIMM drivers (and only those) since this is the main reason for your patchset, as you say, and let me concentrate on writing the trace event I mean - I'm currently travelling but I'll try to hack up something in the next couple of days in order to give you a better idea of what I mean? The edac drivers can use the standard edac_printk and friends in the meantime and we can convert them later. Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551