From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH block/for-linus] block: blk-throttle should be drained regardless of q->elevator
Date: Mon, 13 Feb 2012 15:40:57 -0800 [thread overview]
Message-ID: <20120213234057.GI12117@google.com> (raw)
In-Reply-To: <20120213232742.GH3130@redhat.com>
Hello,
On Mon, Feb 13, 2012 at 06:27:42PM -0500, Vivek Goyal wrote:
> > - /*
> > - * Drain all requests queued before DEAD marking. The caller might
> > - * be trying to tear down @q before its elevator is initialized, in
> > - * which case we don't want to call into draining.
> > - */
> > - if (q->elevator)
> > - blk_drain_queue(q, true);
> > + /* drain all requests queued before DEAD marking */
>
> We have already marked the queue DEAD before we start draining the queue.
> May be we need to fix the comment.
Hmmm... it actually is correct. It drains all requests which were
queued before the preceding DEAD marking. ie... it's describing the
following.
1. requests queued
2. mark q DEAD
3. drain requests which were queued before #2. We don't care
about requests queued after #2.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-02-13 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 22:52 [PATCH block/for-linus] block: blk-throttle should be drained regardless of q->elevator Tejun Heo
2012-02-13 23:27 ` Vivek Goyal
2012-02-13 23:40 ` Tejun Heo [this message]
2012-02-15 15:53 ` Vivek Goyal
2012-02-14 1:14 ` [PATCH UPDATED " Tejun Heo
2012-02-15 15:57 ` Vivek Goyal
2012-02-15 15:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120213234057.GI12117@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox