linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Noonan <steven@uplinklabs.net>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ben Guthro <ben@guthro.net>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: bisected: 'perf top' causing soft lockups under Xen
Date: Wed, 15 Feb 2012 01:32:04 -0800	[thread overview]
Message-ID: <20120215093204.GA17286@asmodeus> (raw)
In-Reply-To: <1329297944.2293.36.camel@twins>

On Wed, Feb 15, 2012 at 10:25:44AM +0100, Peter Zijlstra wrote:
> On Wed, 2012-02-15 at 00:57 -0800, Steven Noonan wrote:
> > It seems to me that there are two options for fixing this, but I'm
> > probably lacking the necessary context (or experience with Xen). Either:
> > 
> > - The patch provided by Ben needs to have additional work to specially
> >   handle IRQ_WORK_VECTOR, since it seems to be a special case where
> >   there's no event channel attached for it. Perhaps adding an event
> >   channel for this is the fix? Seems high-overhead, but I lack a good
> >   understanding of how interrupts are handled in Xen.
> 
> So that's a self-IPI, is Xen failing to implement this?

Yes.

Ben's patch implements it, but it explodes (NULL pointer dereference)
when it can't find an event channel for IRQ_WORK_VECTOR.

> 
> > or
> > 
> > - Perf needs to be "enlightened" about Xen and avoid sending an IPI in
> >   the first place.
> 
> Uhm, no. If anything Xen should simply not implement
> arch_irq_work_raise(). The callbacks are then ran from the timer
> interrupt.

Sorry, wild guess. I'm a kernel newbie. :)

  reply	other threads:[~2012-02-15  9:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10  2:32 bisected: 'perf top' causing soft lockups under Xen Steven Noonan
2012-02-10 16:12 ` Konrad Rzeszutek Wilk
2012-02-10 17:24   ` Peter Zijlstra
2012-02-10 17:28 ` Peter Zijlstra
2012-02-10 19:04   ` Konrad Rzeszutek Wilk
2012-02-11  2:34     ` Ben Guthro
2012-02-12 20:50       ` Steven Noonan
2012-02-15  8:57         ` Steven Noonan
2012-02-15  9:25           ` Peter Zijlstra
2012-02-15  9:32             ` Steven Noonan [this message]
2012-02-15 17:14               ` Konrad Rzeszutek Wilk
2012-02-15 16:17             ` Konrad Rzeszutek Wilk
2012-03-20 15:23               ` Konrad Rzeszutek Wilk
2012-03-20 15:33                 ` Peter Zijlstra
2012-02-10 19:14   ` Steven Noonan
2012-02-10 19:27     ` Steven Noonan
2012-02-10 19:29       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120215093204.GA17286@asmodeus \
    --to=steven@uplinklabs.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=ben@guthro.net \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).