From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] hrtimers: Special-case zero length sleeps
Date: Wed, 15 Feb 2012 14:52:25 +0000 [thread overview]
Message-ID: <20120215145225.GA21448@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1202151537500.2794@ionos>
On Wed, Feb 15, 2012 at 03:40:24PM +0100, Thomas Gleixner wrote:
> > + * be scheduled. Special case that to avoid actually putting them
> > + * to sleep for the duration of the slack.
> > + */
> > + if (rqtp->tv_sec == 0 && rqtp->tv_nsec == 0)
> > + slack = 0;
>
> That's pretty pointless. You can simply return 0 here as
> do_nanosleep() will not call the scheduler on an already expired
> timer, which is always true for a relative timer with delta 0.
I'm actually starting to wonder about the applications doing this. We
default to adding a small amount of slack even if the application has
done sleep(0), which will mean that the timer hasn't expired at this
point. Do we then go through the scheduler differently? Are these
applications actually relying on an invalid assumption?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-02-15 14:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 14:59 [PATCH] hrtimers: Special-case zero length sleeps Matthew Garrett
2012-02-15 14:40 ` Thomas Gleixner
2012-02-15 14:52 ` Matthew Garrett [this message]
2012-02-15 20:14 ` Thomas Gleixner
2012-02-15 20:22 ` Matthew Garrett
2012-02-15 20:30 ` Thomas Gleixner
2012-02-15 20:38 ` Matthew Garrett
2012-02-15 20:40 ` Peter Zijlstra
2012-02-15 20:43 ` Matthew Garrett
2012-02-15 20:46 ` Thomas Gleixner
2012-02-15 20:47 ` Matthew Garrett
2012-02-16 14:27 ` Matthew Garrett
2012-02-16 14:31 ` Alan Cox
2012-02-16 14:51 ` Peter Zijlstra
2012-02-16 15:01 ` Matthew Garrett
2012-02-16 19:09 ` Thomas Gleixner
2012-02-15 14:54 ` Peter Zijlstra
2012-02-15 14:58 ` Matthew Garrett
2012-02-15 20:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215145225.GA21448@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox