public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH UPDATED block/for-linus] block: blk-throttle should be drained regardless of q->elevator
Date: Wed, 15 Feb 2012 10:57:40 -0500	[thread overview]
Message-ID: <20120215155740.GD27312@redhat.com> (raw)
In-Reply-To: <20120214011427.GJ12117@google.com>

On Mon, Feb 13, 2012 at 05:14:27PM -0800, Tejun Heo wrote:

[..]
>  		/*
>  		 * This function might be called on a queue which failed
> -		 * driver init after queue creation.  Some drivers
> -		 * (e.g. fd) get unhappy in such cases.  Kick queue iff
> -		 * dispatch queue has something on it.
> +		 * driver init after queue creation or is not yet fully
> +		 * active yet.  Some drivers (e.g. fd and loop) get unhappy
> +		 * in such cases.  Kick queue iff dispatch queue has
> +		 * something on it and @q has request_fn set.
>  		 */
> -		if (!list_empty(&q->queue_head))
> +		if (!list_empty(&q->queue_head) && q->request_fn)
>  			__blk_run_queue(q);

Is it not a BUG() condition. We have a queue which has some requests
in it and we don't have q->request_fn?

Thanks
Vivek

  reply	other threads:[~2012-02-15 15:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 22:52 [PATCH block/for-linus] block: blk-throttle should be drained regardless of q->elevator Tejun Heo
2012-02-13 23:27 ` Vivek Goyal
2012-02-13 23:40   ` Tejun Heo
2012-02-15 15:53     ` Vivek Goyal
2012-02-14  1:14 ` [PATCH UPDATED " Tejun Heo
2012-02-15 15:57   ` Vivek Goyal [this message]
2012-02-15 15:57   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120215155740.GD27312@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox