* [PATCH] sched: Remove rcu_read_lock/unlock() from select_idle_sibling()
@ 2012-02-17 3:04 Nikunj A. Dadhania
2012-02-22 16:11 ` [tip:sched/core] " tip-bot for Nikunj A. Dadhania
0 siblings, 1 reply; 2+ messages in thread
From: Nikunj A. Dadhania @ 2012-02-17 3:04 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: linux-kernel, Paul E. McKenney
select_idle_sibling() is called from select_task_rq_fair(), which
already has the RCU read lock held.
Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
---
kernel/sched/fair.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4ab60a2..6ce9992 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2670,8 +2670,6 @@ static int select_idle_sibling(struct task_struct *p, int target)
/*
* Otherwise, iterate the domains and find an elegible idle cpu.
*/
- rcu_read_lock();
-
sd = rcu_dereference(per_cpu(sd_llc, target));
for_each_lower_domain(sd) {
sg = sd->groups;
@@ -2693,8 +2691,6 @@ next:
} while (sg != sd->groups);
}
done:
- rcu_read_unlock();
-
return target;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:sched/core] sched: Remove rcu_read_lock/unlock() from select_idle_sibling()
2012-02-17 3:04 [PATCH] sched: Remove rcu_read_lock/unlock() from select_idle_sibling() Nikunj A. Dadhania
@ 2012-02-22 16:11 ` tip-bot for Nikunj A. Dadhania
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Nikunj A. Dadhania @ 2012-02-22 16:11 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, a.p.zijlstra, nikunj, tglx, mingo
Commit-ID: 62f6536a630affe3176deb48554d27ee58b65077
Gitweb: http://git.kernel.org/tip/62f6536a630affe3176deb48554d27ee58b65077
Author: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
AuthorDate: Fri, 17 Feb 2012 08:34:30 +0530
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Wed, 22 Feb 2012 12:28:28 +0100
sched: Remove rcu_read_lock/unlock() from select_idle_sibling()
select_idle_sibling() is called from select_task_rq_fair(), which
already has the RCU read lock held.
Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20120217030409.11748.12491.stgit@abhimanyu
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched/fair.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4ab60a2..6ce9992 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2670,8 +2670,6 @@ static int select_idle_sibling(struct task_struct *p, int target)
/*
* Otherwise, iterate the domains and find an elegible idle cpu.
*/
- rcu_read_lock();
-
sd = rcu_dereference(per_cpu(sd_llc, target));
for_each_lower_domain(sd) {
sg = sd->groups;
@@ -2693,8 +2691,6 @@ next:
} while (sg != sd->groups);
}
done:
- rcu_read_unlock();
-
return target;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-22 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-17 3:04 [PATCH] sched: Remove rcu_read_lock/unlock() from select_idle_sibling() Nikunj A. Dadhania
2012-02-22 16:11 ` [tip:sched/core] " tip-bot for Nikunj A. Dadhania
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox