From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753245Ab2BQQhI (ORCPT ); Fri, 17 Feb 2012 11:37:08 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52841 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670Ab2BQQhF (ORCPT ); Fri, 17 Feb 2012 11:37:05 -0500 Date: Fri, 17 Feb 2012 08:37:01 -0800 From: Mark Brown To: Laxman Dewangan Cc: grant.likely@secretlab.ca, linus.walleij@stericsson.com, rdunlap@xenotime.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH V2 2/3] gpio: gpiolib: Support for open drain/collector gpios Message-ID: <20120217163659.GD10146@opensource.wolfsonmicro.com> References: <1329490582-22107-1-git-send-email-ldewangan@nvidia.com> <1329490582-22107-4-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IDYEmSnFhs3mNXr+" Content-Disposition: inline In-Reply-To: <1329490582-22107-4-git-send-email-ldewangan@nvidia.com> X-Cookie: You have a truly strong individuality. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IDYEmSnFhs3mNXr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 17, 2012 at 08:26:21PM +0530, Laxman Dewangan wrote: > Adding support for the open drain gpio on which client > can specify the open drain property through GPIO flag > GPIOF_OPEN_DRAIN at the time of gpio request. > The open drain pins are normally pulled high and it > cannot be driven to output with value of 1 and so > when client request for setting the pin to HIGH, the > gpio will be set to input direction to make pin in tristate > and hence PULL-UP on pins will make the state to HIGH. > The open drain pin can be driven to LOW by setting output > with value of 0. Reviwed-by: Mark Brown --IDYEmSnFhs3mNXr+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPPoIkAAoJEBus8iNuMP3dVMsP/15Newz7Jvsq8s58AGgzMEFo Gj1kgrfJoh/icSNsf64g3GqCHzQmoT7eePXAJQK18z4YsM6Pd1VxdGVT75FAWaRN O/0Kine5DQmwDPrmpTIJesvYppSP0cIrXPAZJzlj/REnBBXl8X5h9eB8tn19QOzZ 1q7bXngaDwZUIdNDp3QL0oKlk4RCo+yAwBVp7R9nFZf9CH07YMEbu72yc3UD25Bl 1n0akGGAMMmCwJdTQAWtrO3aowrVXOD9LD2XhHpEPS3q23JoQ/BBcRX9H1VfxvG8 MCk8Y+09fDj5WO/O5RqN0/xY8aFfe3GmHy5SLMmnU785z7z0pDljgQWk0mBXXiaR FXEkeYwHHCsY5ZE28h9pPB4SaJVOJNli0qKM+xSUMRCf8d7mbxBycnvgaNtEMbHs y5YhPmK/W/A837xQFv6Tl4VAc5m5HKvkDKNw58UAd6unx8eECxO+mFJ0th7Bmw1e YPF+12HFLIG0XoK/5j3HqzukwXafrSMSUwagi6kb0AJEHYRwmuoPSHOl5h2h8jT/ 1+6wWkrnQUAgwQxpxQUUaNLirlREEcB6QDTlrot3H5yDabs6b3p/ZQaNPLUeE9W4 6RJmp0oa/EKO98pRZ+Ei4NSfumtl0i9R6hg6A+IAWsU6qhgGB4Av1w7BiHM5IT36 68+3GsdrAIoukigUqc3r =/UZE -----END PGP SIGNATURE----- --IDYEmSnFhs3mNXr+--